You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/11 21:39:17 UTC
[GitHub] [arrow] rok opened a new pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
rok opened a new pull request #10697:
URL: https://github.com/apache/arrow/pull/10697
To address [ARROW-13304](https://issues.apache.org/jira/browse/ARROW-13304).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#discussion_r668138827
##########
File path: r/src/arrowExports.cpp
##########
@@ -1807,10 +1807,10 @@ extern "C" SEXP _arrow_dataset___IpcFileWriteOptions__update1(SEXP ipc_options_s
// dataset.cpp
#if defined(ARROW_R_WITH_DATASET)
-void dataset___CsvFileWriteOptions__update(const std::shared_ptr<ds::CsvFileWriteOptions>& csv_options, const std::shared_ptr<arrow::csv::WriteOptions>& write_options);
+void dataset___CsvFileWriteOptions__update(const std::shared_ptr<arrow::ds::CsvFileWriteOptions>& csv_options, const std::shared_ptr<arrow::csv::WriteOptions>& write_options);
extern "C" SEXP _arrow_dataset___CsvFileWriteOptions__update(SEXP csv_options_sexp, SEXP write_options_sexp){
BEGIN_CPP11
- arrow::r::Input<const std::shared_ptr<ds::CsvFileWriteOptions>&>::type csv_options(csv_options_sexp);
+ arrow::r::Input<const std::shared_ptr<arrow::ds::CsvFileWriteOptions>&>::type csv_options(csv_options_sexp);
Review comment:
These changes seem bad - it should be arrow::dataset:: or just ds::.
##########
File path: r/src/arrow_types.h
##########
@@ -37,6 +37,7 @@
#include <arrow/csv/type_fwd.h>
#if defined(ARROW_R_WITH_DATASET)
+#include <arrow/dataset/file_csv.h>
Review comment:
dataset/type_fwd.h already defines arrow::dataset::CsvFileWriteOptions, so it's unclear why this is needed…
##########
File path: r/src/csv.cpp
##########
@@ -191,15 +191,15 @@ std::shared_ptr<arrow::TimestampParser> TimestampParser__MakeISO8601() {
void csv___WriteCSV__Table(const std::shared_ptr<arrow::Table>& table,
const std::shared_ptr<arrow::csv::WriteOptions>& write_options,
const std::shared_ptr<arrow::io::OutputStream>& stream) {
- StopIfNotOk(arrow::csv::WriteCSV(*table, *write_options, stream.get()));
+ arrow::StopIfNotOk(arrow::csv::WriteCSV(*table, *write_options, stream.get()));
Review comment:
Similarly, other files and other builds are all OK with this - so what gives here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok closed pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
rok closed pull request #10697:
URL: https://github.com/apache/arrow/pull/10697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev edited a comment on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
pachadotdev edited a comment on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-878465800
I can confirm this solves the problem, see https://issues.apache.org/jira/browse/ARROW-13304?focusedWorklogId=622975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachadotdev commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
pachadotdev commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-878465800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-878468007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-898405828
Can't reproduce. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-879095886
Let's get CI here fixed (looks like arrowExports.cpp needs to be regenerated?) and have Pacha confirm that the fix still works. I'd still like to see a full install log if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-877865260
https://issues.apache.org/jira/browse/ARROW-13304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-879104391
I mentioned this in Jira, but it might have gotten lost in the shuffle: We [have a crossbow job that installs (using the bundled approach, which is the default for end-users) on 21.04](https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L937-L946) which hasn't failed since it was implemented. What's different between our CI job and the approach that is allegedly failing?
If one wanted to build locally without the bundled approach (in case that's what we think the difference is), the following should work:
```
UBUNTU=21.04 CLANG_TOOLS=9 archery docker run ubuntu-r
```
and to run the job like it is by crossbow (i.e. a bundled build):
```
UBUNTU=21.04 CLANG_TOOLS=9 archery docker run -e ARROW_SOURCE_HOME="/arrow" -e FORCE_BUNDLED_BUILD=TRUE -e LIBARROW_BUILD=TRUE ubuntu-r
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-879094411
Ok, so what shall we do with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-878247507
Hmm, arrow/dataset/type_fwd.h defines CsvFileWriteOptions. Not sure why that's coming up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-887304501
@pachadotdev Can you still reproduce this issue? Otherwise, we may close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-878080533
Moved the import to another location. Guessing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-880607972
> I mentioned this in Jira, but it might have gotten lost in the shuffle: We [have a crossbow job that installs (using the bundled approach, which is the default for end-users) on 21.04](https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L937-L946) which hasn't failed since it was implemented. What's different between our CI job and the approach that is allegedly failing?
>
> If one wanted to build locally without the bundled approach (in case that's what we think the difference is), the following should work:
>
> ```
> UBUNTU=21.04 CLANG_TOOLS=9 archery docker run ubuntu-r
> ```
>
> and to run the job like it is by crossbow (i.e. a bundled build):
>
> ```
> UBUNTU=21.04 CLANG_TOOLS=9 archery docker run -e ARROW_SOURCE_HOME="/arrow" -e FORCE_BUNDLED_BUILD=TRUE -e LIBARROW_BUILD=TRUE ubuntu-r
> ```
Thanks for the archery commands @jonkeane! I've tried these out (had to [update my docker to get around a build issue with gpg](https://stackoverflow.com/questions/66319610/gpg-error-in-ubuntu-21-04-after-second-apt-get-update-during-docker-build#comment118776758_66385784)) and I'm not seeing any errors on either master or this branch. So I'm really not sure what's happening here.
@pachadotdev are you running this on your laptop or in docker? If in docker perhaps you can try rebuilding your image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #10697: ARROW-13304: [C++] Unable to install nightly on Ubuntu 21.04 due to day of week options
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #10697:
URL: https://github.com/apache/arrow/pull/10697#issuecomment-878071626
@lidavidm I don't think this solved the `CsvFileWriterOptions` yet. [See Jira](https://issues.apache.org/jira/browse/ARROW-13304?focusedCommentId=17378814&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17378814).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org