You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/18 09:13:34 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #4387: [SegmentV2] Change the default storage format to SegmentV2
morningman opened a new pull request #4387:
URL: https://github.com/apache/incubator-doris/pull/4387
## Proposed changes
SInce the Segment V2 has been released for a long time, we should make it as default storage format for newly created table.
This CL mainly changes:
1. For all newly created tables, their default storage format is Segment V2.
2. For all already exist tablets, their storage format remain unchanged.
3. Fix bugs described in Fix #4384 and Fix #4385
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
## Checklist
- [x] I have create an issue on (Fix #4386), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
We should provide a more friendly way to check the conversion progress of Segment V2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4387: [SegmentV2] Change the default storage format to SegmentV2
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4387:
URL: https://github.com/apache/incubator-doris/pull/4387#issuecomment-678880183
> > > Why not change the default value of config `default_rowset_type` in `common/config.h` to `BETA`
> >
> >
> > Modifying this config will cause BE to automatically convert all existing data.
> > In fact, this is a very bad design because it is completely uncontrollable. . .
> > But since we have released this feature in version 0.12, even if we make changes, we cannot change the status quo.
> > I will add some explain in document.
>
> We will change it to BETA in 0.13？
> the real default is BETA but the value in config says default is ALPHA this it too werid
yes, but I can't find a good way to solve it. I think we can just leave it and explain it in document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #4387: [SegmentV2] Change the default storage format to SegmentV2
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #4387:
URL: https://github.com/apache/incubator-doris/pull/4387#issuecomment-677043173
> > Why not change the default value of config `default_rowset_type` in `common/config.h` to `BETA`
>
> Modifying this config will cause BE to automatically convert all existing data.
> In fact, this is a very bad design because it is completely uncontrollable. . .
> But since we have released this feature in version 0.12, even if we make changes, we cannot change the status quo.
>
> I will add some explain in document.
We will change it to BETA in 0.13？
the real default is BETA but the value in config says default is ALPHA this it too werid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4387: [SegmentV2] Change the default storage format to SegmentV2
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4387:
URL: https://github.com/apache/incubator-doris/pull/4387#issuecomment-678889358
> Should we remove the config of storage format in BE?
Can not. Because some user already use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4387: [SegmentV2] Change the default storage format to SegmentV2
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4387:
URL: https://github.com/apache/incubator-doris/pull/4387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4387: [SegmentV2] Change the default storage format to SegmentV2
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4387:
URL: https://github.com/apache/incubator-doris/pull/4387#issuecomment-676953448
> Why not change the default value of config `default_rowset_type` in `common/config.h` to `BETA`
Modifying this config will cause BE to automatically convert all existing data.
In fact, this is a very bad design because it is completely uncontrollable. . .
But since we have released this feature in version 0.12, even if we make changes, we cannot change the status quo.
I will add some explain in document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org