You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2010/06/10 14:19:18 UTC
svn commit: r953300 - in /ofbiz/branches/release10.04: ./
applications/product/src/org/ofbiz/product/product/ProductWorker.java
Author: jleroux
Date: Thu Jun 10 12:19:18 2010
New Revision: 953300
URL: http://svn.apache.org/viewvc?rev=953300&view=rev
Log:
"Applied fix from trunk for revision: 953294"
------------------------------------------------------------------------
r953294 | jleroux | 2010-06-10 14:10:24 +0200 (jeu. 10 juin 2010) | 3 lignes
A patch from Sumit Pandit "Average product rating is not calculated properly." (https://issues.apache.org/jira/browse/OFBIZ-3816) - OFBIZ-3816
In ProductWorker.java, method getAverageProductRating is used to calculate product's average rating. It is always return zero.
------------------------------------------------------------------------
Modified:
ofbiz/branches/release10.04/ (props changed)
ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/product/ProductWorker.java
Propchange: ofbiz/branches/release10.04/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Jun 10 12:19:18 2010
@@ -1,3 +1,3 @@
/ofbiz/branches/addbirt:831210-885099,885686-886087
/ofbiz/branches/multitenant20100310:921280-927264
-/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270
+/ofbiz/trunk:939988,939990,939999,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893,951005,951062,951098,951251,951367,951381,951672,952232,952249,952270,953294
Modified: ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/product/ProductWorker.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/product/ProductWorker.java?rev=953300&r1=953299&r2=953300&view=diff
==============================================================================
--- ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/product/ProductWorker.java (original)
+++ ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/product/ProductWorker.java Thu Jun 10 12:19:18 2010
@@ -656,7 +656,7 @@ public class ProductWorker {
BigDecimal rating = productReview.getBigDecimal("productRating");
if (rating != null) {
ratingTally = ratingTally.add(rating);
- numRatings.add(BigDecimal.ONE);
+ numRatings = numRatings.add(BigDecimal.ONE);
}
}
}