You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/01/16 16:57:46 UTC
[kudu-CR] mini-cluster: rename data root to cluster root
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9033
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
mini-cluster: rename data_root to cluster_root
I found that the name data_root for the root directory in which to place
the cluster's data and logs was a confusing name because:
1. we use "data" here loosely to describe any old bytes, encompassing
not only data blocks, but WALs and logs as well, and
2. the concept of a "data root" already exists to mean a
user-specified location to place data blocks (i.e. an entry in
fs_data_dirs).
As such, this patch renames ExternalMiniClusterOptions's data_root to
cluster_root.
Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
7 files changed, 30 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9033/1
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Patch Set 4: Verified+1
The failure was due to a clock sync issue.
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 22:07:46 +0000
Gerrit-HasComments: No
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 19:52:25 +0000
Gerrit-HasComments: No
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
mini-cluster: rename data_root to cluster_root
I found that the name data_root for the root directory in which to place
the cluster's data and logs was a confusing name because:
1. we use "data" here loosely to describe any old bytes, encompassing
not only data blocks, but WALs and logs as well, and
2. the concept of a "data root" already exists to mean a
user-specified location to place data blocks (i.e. an entry in
fs_data_dirs).
As such, this patch renames External- and InternalMiniClusterOptions'
"data_root" members to "cluster_root".
Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Reviewed-on: http://gerrit.cloudera.org:8080/9033
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
10 files changed, 42 insertions(+), 42 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9033/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9033/1//COMMIT_MSG@17
PS1, Line 17: As such, this patch renames ExternalMiniClusterOptions's data_root to
Could you make the same change to the InternalMiniCluster too?
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 18:34:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9033
to look at the new patch set (#2).
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
mini-cluster: rename data_root to cluster_root
I found that the name data_root for the root directory in which to place
the cluster's data and logs was a confusing name because:
1. we use "data" here loosely to describe any old bytes, encompassing
not only data blocks, but WALs and logs as well, and
2. the concept of a "data root" already exists to mean a
user-specified location to place data blocks (i.e. an entry in
fs_data_dirs).
As such, this patch renames External- and InternalMiniClusterOptions'
"data_root" members to "cluster_root".
Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
---
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
10 files changed, 41 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9033/2
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Patch Set 3:
(1 comment)
> Patch Set 3:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/9033/3/src/kudu/mini-cluster/external_mini_cluster.h
File src/kudu/mini-cluster/external_mini_cluster.h:
http://gerrit.cloudera.org:8080/#/c/9033/3/src/kudu/mini-cluster/external_mini_cluster.h@90
PS3, Line 90: // Directory in which to store data.
> Maybe update this?
Done
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 21:04:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9033/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9033/1//COMMIT_MSG@17
PS1, Line 17: As such, this patch renames External- and InternalMiniClusterOptions'
> Could you make the same change to the InternalMiniCluster too?
Done
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 18:52:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 21:12:44 +0000
Gerrit-HasComments: No
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 )
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9033/3/src/kudu/mini-cluster/external_mini_cluster.h
File src/kudu/mini-cluster/external_mini_cluster.h:
http://gerrit.cloudera.org:8080/#/c/9033/3/src/kudu/mini-cluster/external_mini_cluster.h@90
PS3, Line 90: // Directory in which to store data.
Maybe update this?
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 16 Jan 2018 19:14:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] mini-cluster: rename data root to cluster root
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9033
to look at the new patch set (#4).
Change subject: mini-cluster: rename data_root to cluster_root
......................................................................
mini-cluster: rename data_root to cluster_root
I found that the name data_root for the root directory in which to place
the cluster's data and logs was a confusing name because:
1. we use "data" here loosely to describe any old bytes, encompassing
not only data blocks, but WALs and logs as well, and
2. the concept of a "data root" already exists to mean a
user-specified location to place data blocks (i.e. an entry in
fs_data_dirs).
As such, this patch renames External- and InternalMiniClusterOptions'
"data_root" members to "cluster_root".
Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
---
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
10 files changed, 42 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9033/4
--
To view, visit http://gerrit.cloudera.org:8080/9033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8ccc9e232f47a684d6b9226fd84639c4c94d0c3
Gerrit-Change-Number: 9033
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins