You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/30 11:52:39 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43184: [SPARK-44120][PYTHON] Support Python 3.12

HyukjinKwon commented on code in PR #43184:
URL: https://github.com/apache/spark/pull/43184#discussion_r1341950255


##########
python/pyspark/pandas/plot/matplotlib.py:
##########
@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-from distutils.version import LooseVersion
+from packaging.version import Version

Review Comment:
   Oh actually we can't just add a required dependency easily. It works with `pip install` but it wouldn't work when users download Spark from the official website (as they have to manually install `packaging` dependency in their nodes) - in case of Py4J, we already contain that in our release so it works.
   
   We should either port `packaging` into our release, or find a workaround to avoid adding the required dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org