You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/02/05 20:28:31 UTC
Re: Review Request 28686: For DRILL-1735,
hook up JDBC connection closing, and fix follow-on resource bugs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 7:28 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-1735
https://issues.apache.org/jira/browse/DRILL-1735
Repository: drill-git
Description
-------
This change hooks in the previously written but unused DrillHandler so that a local-mode JDBC connection shuts down its embedded DrillBit.
It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed by the original bug fixes. (See the commit message for the list of bugs/fixes and other changes.)
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 04b955b
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java d884200
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 9015a16
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b8480b4
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java 99c6ab8
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 378e81a
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java a8f07b5
exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 7594783
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 2c51ec0
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 88a6c6d
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java b627c38
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java c52eafd
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 28fa4a7
Diff: https://reviews.apache.org/r/28686/diff/
Testing (updated)
-------
Ran tests.
Thanks,
Daniel Barclay
Re: Review Request 28686: For DRILL-1735,
hook up JDBC connection closing, and fix follow-on resource bugs.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/#review72477
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On Feb. 5, 2015, 7:28 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28686/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 7:28 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-1735
> https://issues.apache.org/jira/browse/DRILL-1735
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This change hooks in the previously written but unused DrillHandler so that a local-mode JDBC connection shuts down its embedded DrillBit.
>
> It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed by the original bug fixes. (See the commit message for the list of bugs/fixes and other changes.)
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 04b955b
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java d884200
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java 9015a16
> exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b8480b4
> exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java 99c6ab8
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 378e81a
> exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java a8f07b5
> exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
> exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 7594783
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 2c51ec0
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 88a6c6d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
> exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java b627c38
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java c52eafd
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 28fa4a7
>
> Diff: https://reviews.apache.org/r/28686/diff/
>
>
> Testing
> -------
>
> Ran tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 28686: For DRILL-1735,
hook up JDBC connection closing, and fix follow-on resource bugs.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/#review77154
-----------------------------------------------------------
Ship it!
Perhaps we could change the behavior so that the connection object adds and removes statements from the registry (instead of the statements doing so themselves). Makes the code cleaner. Not a showstopper for this patch.
- Parth Chandra
On March 20, 2015, 12:30 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28686/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 12:30 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-1735
> https://issues.apache.org/jira/browse/DRILL-1735
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This change hooks in the previously written but unused DrillHandler so that a local-mode JDBC connection shuts down its embedded DrillBit.
>
> It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed by the original bug fixes. (See the commit message for the list of bugs/fixes and other changes.)
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java c3a873c
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 2d1a136
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java b079428
> exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9
> exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java b606707
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b8480b4
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 9650ee5
> exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java b6176db
> exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
> exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 82d51f1
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java f19aab0
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java cfcee8c
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 77b2c37
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java fec126e
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java cc797fa
> exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
> exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 40b1445
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 682fca3
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 93925fe
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e
>
> Diff: https://reviews.apache.org/r/28686/diff/
>
>
> Testing
> -------
>
> PENDING (earlier version was working; resolving current problems)
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 28686: For DRILL-1735,
hook up JDBC connection closing, and fix follow-on resource bugs.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/
-----------------------------------------------------------
(Updated March 20, 2015, 12:30 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-1735
https://issues.apache.org/jira/browse/DRILL-1735
Repository: drill-git
Description
-------
This change hooks in the previously written but unused DrillHandler so that a local-mode JDBC connection shuts down its embedded DrillBit.
It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed by the original bug fixes. (See the commit message for the list of bugs/fixes and other changes.)
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java c3a873c
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 2d1a136
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java b079428
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java b606707
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b8480b4
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 9650ee5
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java b6176db
exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 82d51f1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java f19aab0
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java cfcee8c
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 77b2c37
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java fec126e
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java cc797fa
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 40b1445
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 682fca3
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 93925fe
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e
Diff: https://reviews.apache.org/r/28686/diff/
Testing
-------
PENDING (earlier version was working; resolving current problems)
Thanks,
Daniel Barclay
Re: Review Request 28686: For DRILL-1735,
hook up JDBC connection closing, and fix follow-on resource bugs.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/
-----------------------------------------------------------
(Updated March 20, 2015, 12:25 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Rebased on Chris's DRILL-2245 patch.
Bugs: DRILL-1735
https://issues.apache.org/jira/browse/DRILL-1735
Repository: drill-git
Description
-------
This change hooks in the previously written but unused DrillHandler so that a local-mode JDBC connection shuts down its embedded DrillBit.
It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed by the original bug fixes. (See the commit message for the list of bugs/fixes and other changes.)
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java c3a873c
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 2d1a136
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java b079428
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java b606707
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b8480b4
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 9650ee5
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java b6176db
exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 82d51f1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java f19aab0
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java cfcee8c
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 77b2c37
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java fec126e
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java cc797fa
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 40b1445
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 682fca3
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 93925fe
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e
Diff: https://reviews.apache.org/r/28686/diff/
Testing (updated)
-------
PENDING (earlier version was working; resolving current problems)
Thanks,
Daniel Barclay
Re: Review Request 28686: For DRILL-1735,
hook up JDBC connection closing, and fix follow-on resource bugs.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/
-----------------------------------------------------------
(Updated March 19, 2015, 6:19 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Added auto-closing of Statements when Connection is closed.
Bugs: DRILL-1735
https://issues.apache.org/jira/browse/DRILL-1735
Repository: drill-git
Description
-------
This change hooks in the previously written but unused DrillHandler so that a local-mode JDBC connection shuts down its embedded DrillBit.
It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed by the original bug fixes. (See the commit message for the list of bugs/fixes and other changes.)
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 04b955b
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java d884200
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java b079428
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b8480b4
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 8e0780b
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java e2f7bbf
exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 82d51f1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 2c51ec0
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java cfcee8c
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 77b2c37
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java fec126e
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatementRegistry.java cc797fa
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/JdbcTest.java 40b1445
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 682fca3
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 93925fe
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e
Diff: https://reviews.apache.org/r/28686/diff/
Testing
-------
Ran tests.
Thanks,
Daniel Barclay
Re: Review Request 28686: For DRILL-1735,
hook up JDBC connection closing, and fix follow-on resource bugs.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28686/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 9:37 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Rebased on current, not-yet-split patch for 2245 on today's master and re-made patch.
Bugs: DRILL-1735
https://issues.apache.org/jira/browse/DRILL-1735
Repository: drill-git
Description
-------
This change hooks in the previously written but unused DrillHandler so that a local-mode JDBC connection shuts down its embedded DrillBit.
It also fixes a chain of follow-on bugs (mostly resource-deallocation omissions) exposed by the original bug fixes. (See the commit message for the list of bugs/fixes and other changes.)
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 04b955b
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java d884200
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java b079428
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java 3da2ea9
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b8480b4
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java 99c6ab8
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 378e81a
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java 7ccb64e
exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java 0272b23
exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java 82d51f1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java 54e31b1
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 2c51ec0
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java fbe611f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 88a6c6d
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 974e786
exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ConnectionCloseTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcDistQuery.java b2f86ea
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java b627c38
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestMetadataDDL.java 93925fe
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestViews.java 0f9e25e
Diff: https://reviews.apache.org/r/28686/diff/
Testing
-------
Ran tests.
Thanks,
Daniel Barclay