You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2024/11/22 03:35:03 UTC
[PR] Introduce index mode and refactor banyandb group settings [skywalking]
hanahmily opened a new pull request, #12790:
URL: https://github.com/apache/skywalking/pull/12790
* Mark all metrics without value columns as `index_mode`
* Refactor group settings
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce index mode and refactor banyandb group settings [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12790:
URL: https://github.com/apache/skywalking/pull/12790#discussion_r1853242537
##########
docs/en/setup/backend/storages/banyandb.md:
##########
@@ -1,70 +1,115 @@
-
## BanyanDB
-[BanyanDB](https://github.com/apache/skywalking-banyandb) is a dedicated storage implementation developed by the SkyWalking Team and the community.
-Activate BanyanDB as the storage, and set storage provider to **banyandb**.
-The OAP requires BanyanDB 0.7 server. From this version, BanyanDB provides general compatibility.
+[BanyanDB](https://github.com/apache/skywalking-banyandb) is a dedicated storage implementation developed by the SkyWalking Team and the community. Activate BanyanDB as the storage by setting the storage provider to **banyandb**.
+
+The OAP requires BanyanDB version **0.7** or later. From this version onwards, BanyanDB provides general compatibility.
Review Comment:
```suggestion
The OAP requires BanyanDB version **0.8** or later. From this version onwards, BanyanDB provides general compatibility.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce index mode and refactor banyandb group settings [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #12790:
URL: https://github.com/apache/skywalking/pull/12790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce index mode and refactor banyandb group settings [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12790:
URL: https://github.com/apache/skywalking/pull/12790#issuecomment-2492822359
One TODO, we need to update the TTL doc to indicate the default setup in core module is no longer affecting the BanyanDB storage.
And BanyanDB should have its own dedicated advanced setup in the OAP document. This has been tracked by https://github.com/apache/skywalking/issues/12632.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org