You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by trinakrug <gi...@git.apache.org> on 2015/11/30 23:29:17 UTC
[GitHub] incubator-trafodion pull request: TRAFODION-1626 fix for dtmci sta...
GitHub user trinakrug opened a pull request:
https://github.com/apache/incubator-trafodion/pull/196
TRAFODION-1626 fix for dtmci statis -j
Errors were not being checked after the TMSTATS call for the "json" case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trinakrug/incubator-trafodion tktraf_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #196
----
commit ef04905e245cf072014c8f005ee3b7962a01bba8
Author: Trina Krug <tr...@dev01.trafodion.org>
Date: 2015-11-30T22:27:28Z
TRAFODION-1626 fix for dtmci statis -j
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1626 fix for dtmci sta...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/196#discussion_r46218270
--- Diff: core/sqf/src/tm/tools/dtmci.cpp ---
@@ -472,23 +472,22 @@ void process_tmstats_node(bool pv_reset, int32 pv_nid, bool json)
lv_error = TMSTATS(pv_nid, &lv_stats, pv_reset);
- if(json==false) {
- if (lv_error)
- printf("Node %d\t**Error %d.", pv_nid, lv_error);
- else
- {
- printf("Node %d:", pv_nid);
- print_counters(&lv_stats.iv_counts);
- print_txnStats(&lv_stats.iv_txn);
-
- // Pool statistics
- printf("\n Txn Pool:\t");
- print_poolStats(lv_stats.iv_transactionPool_stats);
- printf("\n Thrd Pool:\t");
- print_poolStats(lv_stats.iv_threadPool_stats);
- printf("\n RMMsg Pool:\t");
- print_poolStats(lv_stats.iv_RMMessagePool_stats);
- }
+ if (lv_error) {
+ printf("Node %d\t**Error %d.\n", pv_nid, lv_error);
--- End diff --
Should the error be reported as a JSON document in the JSON case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1626 fix for dtmci sta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---