missing org/apache/mahout/math/function/DoubleFunction (?)

[Andre Schumacher <an...@gmail.com>]

Dear all,

I'm new to Mahout (and quite new to machine learning in general) but I was
wondering whether there may be a problem with the current SVN version
and missing class called DoubleFunction (part of ...math/function).

My concrete problem is that I would like to use SVDRecommender
together with ALSWRFactorizer and I get a missing class error
for DoubleFunction. I googled a bit and it seems that there used to
be a class called DoubleFunction but now there is only
DoubleDoubleFunction.

My question would be if there are pending changes to math vector/matrix
classes and if DoubleDoubleFunction has replaced DoubleFunction?

Thankful for any comments..

Andre

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Sean Owen <sr...@gmail.com>]

Done, I resurrected the file as a simple step to something at least
consistent.

On Fri, Feb 25, 2011 at 9:33 PM, Sean Owen <sr...@gmail.com> wrote:

> Oops. *Procedure is not the same thing (it returns a boolean).
>
> Ideally all the *Procedure and *Function interfaces would be in one place.
> This would mean re-releasing collections. I don't know if there's appetite
> to bother.
>
> Or I can put DoubleFunction back in math. That's not the ideal-est place
> for it, but it's consistent.
>

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Sean Owen <sr...@gmail.com>]

Oops. *Procedure is not the same thing (it returns a boolean).

Ideally all the *Procedure and *Function interfaces would be in one place.
This would mean re-releasing collections. I don't know if there's appetite
to bother.

Or I can put DoubleFunction back in math. That's not the ideal-est place for
it, but it's consistent.

On Fri, Feb 25, 2011 at 5:40 PM, Ted Dunning <te...@gmail.com> wrote:

> +1
>
> This really does need cleaning up.  The sooner the better.
>
>
>

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Ted Dunning <te...@gmail.com>]

+1

This really does need cleaning up.  The sooner the better.

On Fri, Feb 25, 2011 at 6:30 AM, Sean Owen <sr...@gmail.com> wrote:

> We also have identical interfaces like DoubleProcedure and
> DoubleDoubleProcedure, from Colt. I suggest we not keep both copies. We
> could for instance delete DoubleFunction and replace with DoubleProcedure.
> It's exactly the same thing interface-wise. Same more several other
> *Function classes.
>
> Anyone object or have better designs?
>

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Sean Owen <sr...@gmail.com>]

I think we have some confusion between mahout-math and
mahout-collections. Both contain org.apache.mahout.math code, and in some
cases duplicate copies.

I think the best fix is actually to move things like DoubleDoubleFunction
out of mahout-math; they exist in mahout-collections which, despite the
module names, seems to be the home for interfaces like this.

We also have identical interfaces like DoubleProcedure and
DoubleDoubleProcedure, from Colt. I suggest we not keep both copies. We
could for instance delete DoubleFunction and replace with DoubleProcedure.
It's exactly the same thing interface-wise. Same more several other
*Function classes.

Anyone object or have better designs?

On Fri, Feb 25, 2011 at 12:25 PM, Andre Schumacher <andre.schumach@gmail.com
> wrote:

>
> Hi,
>
> Thanks for the quick reply. I added mahout-collections to the classpath
> and now it seems to work.
>
> On Fri, Feb 25, 2011 at 12:49 PM, Sean Owen <sr...@gmail.com> wrote:
>
>> Oops. I correct myself. It still exists in mahout-collections somehow,
>> but was removed from mahout-math as it was unused. You should not need
>> it, as a result. I would make sure you are building from head in
>> Subversion to ensure you have a consistent set of code.
>>
>
> I was building from head (revision 1074453). There it seems that
> DoubleFunction was imported by org.apache.mahout.math.Vector.
>
> Best regards,
>
> Andre
>

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Andre Schumacher <an...@gmail.com>]

Hi,

Thanks for the quick reply. I added mahout-collections to the classpath
and now it seems to work.

On Fri, Feb 25, 2011 at 12:49 PM, Sean Owen <sr...@gmail.com> wrote:

> Oops. I correct myself. It still exists in mahout-collections somehow,
> but was removed from mahout-math as it was unused. You should not need
> it, as a result. I would make sure you are building from head in
> Subversion to ensure you have a consistent set of code.
>

I was building from head (revision 1074453). There it seems that
DoubleFunction was imported by org.apache.mahout.math.Vector.

Best regards,

Andre

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Sean Owen <sr...@gmail.com>]

Oops. I correct myself. It still exists in mahout-collections somehow,
but was removed from mahout-math as it was unused. You should not need
it, as a result. I would make sure you are building from head in
Subversion to ensure you have a consistent set of code.

On Fri, Feb 25, 2011 at 10:43 AM, Sean Owen <sr...@gmail.com> wrote:
> DoubleFunction has not been removed, no. It is in the math package.
> You need to make sure you have mahout-math in your classpath too.

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Sean Owen <sr...@gmail.com>]

DoubleFunction has not been removed, no. It is in the math package.
You need to make sure you have mahout-math in your classpath too.

On Fri, Feb 25, 2011 at 10:35 AM, Andre Schumacher
<an...@gmail.com> wrote:
> Dear all,
>
> I'm new to Mahout (and quite new to machine learning in general) but I was
> wondering whether there may be a problem with the current SVN version
> and missing class called DoubleFunction (part of ...math/function).
>
> My concrete problem is that I would like to use SVDRecommender
> together with ALSWRFactorizer and I get a missing class error
> for DoubleFunction. I googled a bit and it seems that there used to
> be a class called DoubleFunction but now there is only
> DoubleDoubleFunction.
>
> My question would be if there are pending changes to math vector/matrix
> classes and if DoubleDoubleFunction has replaced DoubleFunction?
>
> Thankful for any comments..
>
> Andre
>

Re: missing org/apache/mahout/math/function/DoubleFunction (?)

[Sebastian Schelter <ss...@googlemail.com>]

Hello Andre,

Could you post the stacktrace of your error? I guess there must be some 
problem with your local setup as the builds on our continuous 
integration system work fine.

--sebastian



On 25.02.2011 11:35, Andre Schumacher wrote:
> Dear all,
>
> I'm new to Mahout (and quite new to machine learning in general) but I was
> wondering whether there may be a problem with the current SVN version
> and missing class called DoubleFunction (part of ...math/function).
>
> My concrete problem is that I would like to use SVDRecommender
> together with ALSWRFactorizer and I get a missing class error
> for DoubleFunction. I googled a bit and it seems that there used to
> be a class called DoubleFunction but now there is only
> DoubleDoubleFunction.
>
> My question would be if there are pending changes to math vector/matrix
> classes and if DoubleDoubleFunction has replaced DoubleFunction?
>
> Thankful for any comments..
>
> Andre
>