You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/03 16:26:25 UTC
[GitHub] [shardingsphere] tain198127 opened a new pull request, #18816: fix issues 15707
tain198127 opened a new pull request, #18816:
URL: https://github.com/apache/shardingsphere/pull/18816
Fixes #15707.
Changes proposed in this pull request:
- rename MySQLJdbcDumperTest to MySQLInventoryDumperTest
- add more test case for YEAR_DATE_TYPE in MySQLInventoryDumper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18816: fix issues 15707
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18816:
URL: https://github.com/apache/shardingsphere/pull/18816#issuecomment-1173138276
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18816](https://codecov.io/gh/apache/shardingsphere/pull/18816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b692ab1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/543b190f8835701bb89b95346973af49a2cbab9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (543b190) will **increase** coverage by `0.02%`.
> The diff coverage is `95.00%`.
```diff
@@ Coverage Diff @@
## master #18816 +/- ##
============================================
+ Coverage 59.18% 59.20% +0.02%
Complexity 2275 2275
============================================
Files 3741 3741
Lines 54256 54273 +17
Branches 9162 9163 +1
============================================
+ Hits 32113 32135 +22
+ Misses 19443 19438 -5
Partials 2700 2700
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/18816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9Db250ZXh0TWFuYWdlci5qYXZh) | `69.92% <95.00%> (+3.13%)` | :arrow_up: |
| [...ta/pipeline/mysql/ingest/MySQLInventoryDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/18816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L015U1FMSW52ZW50b3J5RHVtcGVyLmphdmE=) | `84.61% <0.00%> (+15.38%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [58a7731...b692ab1](https://codecov.io/gh/apache/shardingsphere/pull/18816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on a diff in pull request #18816: fix issues 15707
Posted by GitBox <gi...@apache.org>.
tain198127 commented on code in PR #18816:
URL: https://github.com/apache/shardingsphere/pull/18816#discussion_r913345453
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/src/test/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/MySQLInventoryDumperTest.java:
##########
@@ -30,24 +39,16 @@
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
-import javax.sql.DataSource;
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.ResultSetMetaData;
-import java.sql.SQLException;
-import java.sql.Statement;
-import java.sql.Types;
-
+import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
-public final class MySQLJdbcDumperTest {
-
+public final class MySQLInventoryDumperTest {
+
private MySQLInventoryDumper mysqlJdbcDumper;
-
+
Review Comment:
fix it last commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tain198127 commented on pull request #18816: fix issues 15707
Posted by GitBox <gi...@apache.org>.
tain198127 commented on PR #18816:
URL: https://github.com/apache/shardingsphere/pull/18816#issuecomment-1173131540
before I commit, Line coverage(the third column) was not 100% yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #18816: Improve unit test of MySQLInventoryDumper
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #18816:
URL: https://github.com/apache/shardingsphere/pull/18816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #18816: fix issues 15707
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #18816:
URL: https://github.com/apache/shardingsphere/pull/18816#discussion_r912638087
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/src/test/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/MySQLInventoryDumperTest.java:
##########
@@ -30,24 +39,16 @@
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
-import javax.sql.DataSource;
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.ResultSetMetaData;
-import java.sql.SQLException;
-import java.sql.Statement;
-import java.sql.Types;
-
+import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
-public final class MySQLJdbcDumperTest {
-
+public final class MySQLInventoryDumperTest {
+
private MySQLInventoryDumper mysqlJdbcDumper;
-
+
Review Comment:
Whitespaces should be kept.
You could download and setup code style in IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #18816: Improve unit test of MySQLInventoryDumper
Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #18816:
URL: https://github.com/apache/shardingsphere/pull/18816#issuecomment-1174569456
@tain198127 Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org