You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "abetomo (via GitHub)" <gi...@apache.org> on 2023/06/30 01:46:25 UTC

[GitHub] [arrow] abetomo commented on issue #34567: [JS] Remove bin/bin directory from bundles

abetomo commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1614001985

   I haven't looked into it in detail, but the following patch may improve it.
   
   ```diff
   --- a/js/gulp/typescript-task.js
   +++ b/js/gulp/typescript-task.js
   @@ -34,7 +34,6 @@ export const typescriptTask = ((cache) => memoizeTask(cache, function typescript
        const out = targetDir(target, format);
        const tsconfigPath = path.join(`tsconfig`, `tsconfig.${tsconfigName(target, format)}.json`);
        return compileTypescript(out, tsconfigPath)
   -        .pipe(mergeWith(compileBinFiles(target, format)))
            .pipe(takeLast(1))
            .pipe(share({ connector: () => new ReplaySubject(), resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }))
    }))({});
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org