You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/07/01 01:20:17 UTC
Review Request 36070: DRILL-3243: Need a better error message - Use
of alias in window function definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36070/
-----------------------------------------------------------
Review request for drill and Hanifi Gunes.
Bugs: DRILL-3243
https://issues.apache.org/jira/browse/DRILL-3243
Repository: drill-git
Description
-------
improved error message and added a unit test
Diffs
-----
common/src/main/java/org/apache/drill/common/exceptions/UserException.java 13c17bd
common/src/main/java/org/apache/drill/common/exceptions/UserRemoteException.java 1b3fa42
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java 254e0d8
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/RepeatedVarCharOutput.java 40276f4
exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f9
Diff: https://reviews.apache.org/r/36070/diff/
Testing
-------
all unit tests are passing along with functional and tpch100
Thanks,
abdelhakim deneche
Re: Review Request 36070: DRILL-3243: Need a better error message -
Use of alias in window function definition
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36070/#review90194
-----------------------------------------------------------
Ship it!
- Hanifi Gunes
On June 30, 2015, 11:20 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36070/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 11:20 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Bugs: DRILL-3243
> https://issues.apache.org/jira/browse/DRILL-3243
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> improved error message and added a unit test
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/exceptions/UserException.java 13c17bd
> common/src/main/java/org/apache/drill/common/exceptions/UserRemoteException.java 1b3fa42
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java 254e0d8
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/RepeatedVarCharOutput.java 40276f4
> exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f9
>
> Diff: https://reviews.apache.org/r/36070/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>