You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Lorenz Quack (JIRA)" <ji...@apache.org> on 2015/04/24 15:00:39 UTC
[jira] [Updated] (QPID-6508) PropertiesFileInitialContextFactory
silences important exceptions and is non-compliant with the InitialContext
interface
[ https://issues.apache.org/jira/browse/QPID-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lorenz Quack updated QPID-6508:
-------------------------------
Attachment: 0001-QPID-6506-QPID-6508-Java-Client-PropertiesFileInitia.patch
Keith, could you please review my patch.
> PropertiesFileInitialContextFactory silences important exceptions and is non-compliant with the InitialContext interface
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-6508
> URL: https://issues.apache.org/jira/browse/QPID-6508
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.32
> Reporter: Lorenz Quack
> Priority: Minor
> Attachments: 0001-QPID-6506-QPID-6508-Java-Client-PropertiesFileInitia.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> 1) PropertiesFileInitialContextFactory.getInitialContext catches IOExceptions and URISyntaxExceptions logs a warning and then does not re-throw the exception.
> If users don't have logging set to warning they will miss important information.
> 2) PropertiesFileInitialContextFactory.getInitialContext modifies the environment parameter which is not conformant. To quote the InitialContextFactory.getInitialContext JavaDoc: "The environment parameter is owned by the caller. The implementation will _not modify the object_ or keep a reference to it \[...\]" (emphasis mine)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org