You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2023/06/28 03:33:22 UTC
[GitHub] [druid] gianm opened a new pull request, #14494: Update .asf.yaml to simplify email subjects.
gianm opened a new pull request, #14494:
URL: https://github.com/apache/druid/pull/14494
Currently, github notification emails to commits@druid.apache.org have a wide variety of subject lines. This foils email client threading and makes the firehose of emails hard to follow. This is an attempt, inspired by the config for plc4x, to make the emails easier to follow.
After this change, it may even make sense to send some to dev@ instead of commits@.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a diff in pull request #14494: Update .asf.yaml to simplify email subjects.
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on code in PR #14494:
URL: https://github.com/apache/druid/pull/14494#discussion_r1245014626
##########
.asf.yaml:
##########
@@ -1,3 +1,34 @@
+# note: documentation can be found here https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features
+
github:
description: 'Apache Druid: a high performance real-time analytics database.'
homepage: https://druid.apache.org/
+
+ # Attempt to make the auto-generated github emails more easily readable in email clients.
+ # Configuration adapted from https://github.com/apache/plc4x/blob/develop/.asf.yaml.
+ custom_subjects:
+ new_pr: "[PR] {title}"
+ close_pr: "Re: [PR] {title}"
+ comment_pr: "Re: [PR] {title}"
+ diffcomment: "Re: [PR] {title}"
+ merge_pr: "Re: [PR] {title}"
+ new_issue: "[I] {title}"
+ comment_issue: "Re: [I] {title}"
+ close_issue: "Re: [I] {title}"
+ catchall: "[GH] {title}"
+ new_discussion: "[D] {title}"
+ edit_discussion: "Re: [D] {title}"
+ close_discussion: "Re: [D] {title}"
+ close_discussion_with_comment: "Re: [D] {title}"
+ reopen_discussion: "Re: [D] {title}"
+ new_comment_discussion: "Re: [D] {title}"
+ edit_comment_discussion: "Re: [D] {title}"
+ delete_comment_discussion: "Re: [D] {title}"
Review Comment:
TIL about [github discussions](https://docs.github.com/en/discussions), though I think they are not actually enabled for our project? Sounds pretty nice, but it seems like it should for sure go to the dev list if we had them turned on - assuming these changes make things nice and tidy/threaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #14494: Update .asf.yaml to simplify email subjects.
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #14494:
URL: https://github.com/apache/druid/pull/14494#issuecomment-1611849303
The CI failures aren't related. (This patch doesn't change any code.) I am not sure what's going on with them, but I'll merge this PR since it seems safe CI-wise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #14494: Update .asf.yaml to simplify email subjects.
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #14494:
URL: https://github.com/apache/druid/pull/14494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org