[GitHub] [airflow] dimberman commented on a diff in pull request #29206: Add non login-password auth support for SimpleHttpOpeator

["dimberman (via GitHub)" <gi...@apache.org>]

dimberman commented on code in PR #29206:
URL: https://github.com/apache/airflow/pull/29206#discussion_r1104003773


##########
airflow/providers/http/hooks/http.py:
##########
@@ -95,6 +98,11 @@ def get_conn(self, headers: dict[Any, Any] | None = None) -> requests.Session:
                 self.base_url = self.base_url + ":" + str(conn.port)
             if conn.login:
                 session.auth = self.auth_type(conn.login, conn.password)
+            elif self.auth_type is not None and self.auth_type is not HTTPBasicAuth:

Review Comment:
   Yeah I'm a fan of this approach. If we have this set do we even need to check if auth type is none though? Won't it always be _auth_type or HTTPBasicAuth?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org