You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Shreyas220 (via GitHub)" <gi...@apache.org> on 2025/05/06 20:30:16 UTC
[PR] dont fail when last-column-id is 0 or schema len is 0 [iceberg-go]
Shreyas220 opened a new pull request, #421:
URL: https://github.com/apache/iceberg-go/pull/421
solves #405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] dont fail when last-column-id is 0 [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #421:
URL: https://github.com/apache/iceberg-go/pull/421#discussion_r2076436259
##########
table/metadata.go:
##########
@@ -1190,6 +1194,9 @@ func (m *metadataV2) UnmarshalJSON(b []byte) error {
type Alias metadataV2
aux := (*Alias)(m)
+ // Set LastColumnId to -1 to indicate that it is not set as LastColumnId = 0 is a valid value for when no schema is present
+ aux.LastColumnId = -1
Review Comment:
same comment as above
##########
table/metadata.go:
##########
@@ -1145,6 +1146,9 @@ func (m *metadataV1) UnmarshalJSON(b []byte) error {
type Alias metadataV1
aux := (*Alias)(m)
+ // Set LastColumnId to -1 to indicate that it is not set as LastColumnId = 0 is a valid value for when no schema is present
+ aux.LastColumnId = -1
Review Comment:
`last-column-id` is a required attribute, so it should never be missing. So I don't think we need to do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] dont fail when last-column-id is 0 [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #421:
URL: https://github.com/apache/iceberg-go/pull/421#issuecomment-2856286543
Looks good once the linting is taken care of :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] dont fail when last-column-id is 0 [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #421:
URL: https://github.com/apache/iceberg-go/pull/421#discussion_r2076436060
##########
table/metadata.go:
##########
@@ -1145,6 +1146,9 @@ func (m *metadataV1) UnmarshalJSON(b []byte) error {
type Alias metadataV1
aux := (*Alias)(m)
+ // Set LastColumnId to -1 to indicate that it is not set as LastColumnId = 0 is a valid value for when no schema is present
+ aux.LastColumnId = -1
Review Comment:
`last-column-id` is a required attribute, so it should never be missing. So I don't think we need to do this
##########
table/metadata.go:
##########
@@ -1190,6 +1194,9 @@ func (m *metadataV2) UnmarshalJSON(b []byte) error {
type Alias metadataV2
aux := (*Alias)(m)
+ // Set LastColumnId to -1 to indicate that it is not set as LastColumnId = 0 is a valid value for when no schema is present
+ aux.LastColumnId = -1
Review Comment:
same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] dont fail when last-column-id is 0 [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #421:
URL: https://github.com/apache/iceberg-go/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org