You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zzzxl1993 (via GitHub)" <gi...@apache.org> on 2024/01/26 06:33:35 UTC

[PR] [feature](invert index) does not create an inverted index to support … [doris]

zzzxl1993 opened a new pull request, #30414:
URL: https://github.com/apache/doris/pull/30414

   …the match_phrase_prefix feature.
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1913864537

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1911594207

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 186196 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c3c14643be607439a1259ba356e84ee795bd29df, data reload: false
   
   query1	932	339	322	322
   query2	6573	1990	1871	1871
   query3	6706	204	200	200
   query4	33285	22338	22216	22216
   query5	4454	434	357	357
   query6	241	153	152	152
   query7	4611	279	252	252
   query8	219	169	175	169
   query9	8338	2598	2574	2574
   query10	404	215	218	215
   query11	16906	15491	15672	15491
   query12	123	70	64	64
   query13	1663	397	375	375
   query14	10446	6850	6906	6850
   query15	202	177	183	177
   query16	5811	253	251	251
   query17	945	467	474	467
   query18	1787	260	245	245
   query19	176	129	133	129
   query20	67	67	66	66
   query21	191	120	128	120
   query22	4919	4946	4676	4676
   query23	31676	30629	30753	30629
   query24	12914	2867	2834	2834
   query25	589	315	311	311
   query26	1834	143	149	143
   query27	3329	287	283	283
   query28	7243	1829	1822	1822
   query29	2183	624	620	620
   query30	280	134	139	134
   query31	929	732	758	732
   query32	75	49	48	48
   query33	707	209	214	209
   query34	1303	440	462	440
   query35	870	802	795	795
   query36	1369	1215	1243	1215
   query37	177	60	56	56
   query38	3350	3271	3243	3243
   query39	1307	1275	1272	1272
   query40	351	84	83	83
   query41	37	34	33	33
   query42	91	89	87	87
   query43	515	483	461	461
   query44	1070	695	696	695
   query45	188	170	171	170
   query46	1051	636	660	636
   query47	1664	1544	1559	1544
   query48	375	307	298	298
   query49	1224	282	284	282
   query50	663	308	310	308
   query51	5278	5243	5240	5240
   query52	95	72	73	72
   query53	314	248	256	248
   query54	243	178	183	178
   query55	83	74	77	74
   query56	171	156	163	156
   query57	1040	929	888	888
   query58	186	155	156	155
   query59	2897	2646	2700	2646
   query60	204	179	178	178
   query61	87	83	86	83
   query62	589	355	349	349
   query63	274	257	254	254
   query64	6116	1792	1740	1740
   query65	3303	3237	3239	3237
   query66	1436	317	324	317
   query67	15538	15203	15467	15203
   query68	12103	520	525	520
   query69	573	293	288	288
   query70	1719	1496	1512	1496
   query71	10452	10191	10194	10191
   query72	5456	2806	2837	2806
   query73	2596	316	316	316
   query74	7127	6326	6338	6326
   query75	4876	2296	2334	2296
   query76	6514	1045	990	990
   query77	630	226	225	225
   query78	9058	8903	8598	8598
   query79	1001	486	491	486
   query80	561	312	310	310
   query81	458	198	204	198
   query82	203	76	77	76
   query83	133	116	119	116
   query84	265	67	66	66
   query85	1117	363	323	323
   query86	389	393	405	393
   query87	3557	3326	3328	3326
   query88	2831	2185	2182	2182
   query89	409	342	329	329
   query90	1999	187	189	187
   query91	151	129	145	129
   query92	49	43	44	43
   query93	1942	425	439	425
   query94	1273	155	155	155
   query95	505	453	448	448
   query96	616	308	316	308
   query97	4267	4137	4136	4136
   query98	218	200	186	186
   query99	1010	703	682	682
   Total cold run time: 308275 ms
   Total hot run time: 186196 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1911598510

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 29.22 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c3c14643be607439a1259ba356e84ee795bd29df, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.02	0.02
   query3	0.23	0.04	0.04
   query4	1.70	0.07	0.07
   query5	0.54	0.52	0.53
   query6	1.27	0.62	0.63
   query7	0.01	0.01	0.02
   query8	0.03	0.02	0.03
   query9	0.54	0.49	0.50
   query10	0.58	0.55	0.58
   query11	0.12	0.09	0.08
   query12	0.12	0.10	0.09
   query13	0.60	0.61	0.60
   query14	0.80	0.80	0.80
   query15	0.80	0.77	0.77
   query16	0.39	0.37	0.37
   query17	1.02	1.04	0.99
   query18	0.23	0.27	0.24
   query19	1.86	1.80	1.78
   query20	0.01	0.01	0.01
   query21	15.39	0.54	0.54
   query22	2.30	2.59	1.06
   query23	17.06	0.84	0.70
   query24	2.60	1.42	0.26
   query25	0.43	0.22	0.11
   query26	0.48	0.14	0.13
   query27	0.05	0.06	0.05
   query28	12.54	0.76	0.75
   query29	12.54	3.18	3.10
   query30	0.51	0.48	0.48
   query31	2.78	0.34	0.34
   query32	3.37	0.48	0.48
   query33	3.25	3.22	3.18
   query34	15.73	4.39	4.32
   query35	4.29	4.32	4.31
   query36	1.13	1.08	1.07
   query37	0.06	0.05	0.05
   query38	0.04	0.02	0.03
   query39	0.02	0.02	0.01
   query40	0.16	0.13	0.13
   query41	0.08	0.02	0.01
   query42	0.02	0.01	0.02
   query43	0.03	0.02	0.01
   Total cold run time: 105.8 s
   Total hot run time: 29.22 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "qidaye (via GitHub)" <gi...@apache.org>.
qidaye merged PR #30414:
URL: https://github.com/apache/doris/pull/30414


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30414:
URL: https://github.com/apache/doris/pull/30414#discussion_r1467273494


##########
be/src/vec/functions/match.cpp:
##########
@@ -311,6 +311,65 @@ Status FunctionMatchPhrase::execute_match(const std::string& column_name,
     return Status::OK();
 }
 
+Status FunctionMatchPhrasePrefix::execute_match(

Review Comment:
   warning: method 'execute_match' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
   static Status FunctionMatchPhrasePrefix::execute_match(
   ```
   
   be/src/vec/functions/match.cpp:316:
   ```diff
   -         const ColumnArray::Offsets64* array_offsets, ColumnUInt8::Container& result) const {
   +         const ColumnArray::Offsets64* array_offsets, ColumnUInt8::Container& result) {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1912876024

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "zzzxl1993 (via GitHub)" <gi...@apache.org>.
zzzxl1993 commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1911554515

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1911600862

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit c3c14643be607439a1259ba356e84ee795bd29df with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1911584006

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38865 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c3c14643be607439a1259ba356e84ee795bd29df, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17687	5374	5300	5300
   q2	2037	139	127	127
   q3	10650	1146	1161	1146
   q4	10221	791	807	791
   q5	7724	3173	3155	3155
   q6	193	122	121	121
   q7	851	486	482	482
   q8	9246	1897	1944	1897
   q9	7190	6406	6356	6356
   q10	8212	3004	3010	3004
   q11	424	207	201	201
   q12	349	192	189	189
   q13	17980	3400	3349	3349
   q14	250	216	212	212
   q15	541	509	500	500
   q16	426	371	403	371
   q17	940	563	501	501
   q18	7547	6898	6804	6804
   q19	1584	1355	1358	1355
   q20	556	324	295	295
   q21	2756	2409	2467	2409
   q22	358	307	300	300
   Total cold run time: 107722 ms
   Total hot run time: 38865 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5537	5277	5222	5222
   q2	327	217	214	214
   q3	3342	3241	3224	3224
   q4	2122	2095	2112	2095
   q5	5989	5938	5970	5938
   q6	197	119	118	118
   q7	2304	1885	1897	1885
   q8	3242	3392	3418	3392
   q9	9112	9083	9029	9029
   q10	4248	3958	4056	3958
   q11	579	480	484	480
   q12	862	644	648	644
   q13	18841	3389	3376	3376
   q14	300	256	273	256
   q15	548	497	509	497
   q16	520	452	478	452
   q17	1895	1847	1846	1846
   q18	9697	9151	9432	9151
   q19	21487	1583	1509	1509
   q20	4571	1948	1926	1926
   q21	14190	5169	5372	5169
   q22	969	543	518	518
   Total cold run time: 110879 ms
   Total hot run time: 60899 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](invert index) does not create an inverted index to support … [doris]

Posted by "zzzxl1993 (via GitHub)" <gi...@apache.org>.
zzzxl1993 commented on PR #30414:
URL: https://github.com/apache/doris/pull/30414#issuecomment-1911677550

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org