You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by gcaragea <gi...@git.apache.org> on 2016/04/06 21:11:55 UTC
[GitHub] incubator-hawq pull request: HAWQ-633. Don't error out if we canno...
GitHub user gcaragea opened a pull request:
https://github.com/apache/incubator-hawq/pull/562
HAWQ-633. Don't error out if we cannot delete workfile directory during AbortXact
If we reach out of disk space when creating temporary spill files, we will error out during writing to disk, and abort the transaction.
When aborting the transaction, part of the cleanup code we call workfile_mgr_unlink_directory() to delete the directory containing all the work files. But in some cases that directory might not even be created, because of the out of disk space.
Instead of erroring out again, just give a warning and continue with the abort code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gcaragea/incubator-hawq workfile-unlink-abrt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #562
----
commit d9be73b18fe8a17ed44f70de765b35faf8380ba4
Author: George Caragea <gc...@pivotal.io>
Date: 2016-04-06T18:52:56Z
HAWQ-633. Don't error out if we cannot delete workfile directory during AbortTransaction.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-633. Don't error out if we canno...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/562#issuecomment-206672191
@gcaragea, merged into master branch. please close this PR. Thank.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-633. Don't error out if we canno...
Posted by gcaragea <gi...@git.apache.org>.
Github user gcaragea closed the pull request at:
https://github.com/apache/incubator-hawq/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-633. Don't error out if we canno...
Posted by gcaragea <gi...@git.apache.org>.
Github user gcaragea commented on the pull request:
https://github.com/apache/incubator-hawq/pull/562#issuecomment-206983663
Merged to master. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-633. Don't error out if we canno...
Posted by gcaragea <gi...@git.apache.org>.
Github user gcaragea commented on the pull request:
https://github.com/apache/incubator-hawq/pull/562#issuecomment-206517966
@liming01 Can you please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-633. Don't error out if we canno...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/562#issuecomment-206667659
Looks fine. +1. Many thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---