You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/30 10:39:42 UTC
[GitHub] [inlong] Greedyu opened a new pull request, #4822: [INLONG-4821][Agent] Modify Agent module exception: null value for key job.instance.id
Greedyu opened a new pull request, #4822:
URL: https://github.com/apache/inlong/pull/4822
### Prepare a Pull Request
When the manager module initializes the loading job, the trigger object is read and an exception occurs: null value for key job.instance.id
- Fixes #4821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Greedyu commented on a diff in pull request #4822: [INLONG-4821][Agent] Fix the error of null value for key job.instance.id
Posted by GitBox <gi...@apache.org>.
Greedyu commented on code in PR #4822:
URL: https://github.com/apache/inlong/pull/4822#discussion_r910929377
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/db/RocksDbImp.java:
##########
@@ -239,11 +257,11 @@ public List<KeyValueEntity> search(StateSearchKey searchKey) {
public List<CommandEntity> searchCommands(boolean isAcked) {
List<CommandEntity> results = new LinkedList<>();
try (final RocksIterator it = db.newIterator(
- columnHandlesMap.get(commandFamilyName))) {
+ columnHandlesMap.get(commandFamilyName))) {
Review Comment:
The RocksDbImp class has been formatted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #4822: [INLONG-4821][Agent] Fix the error of null value for key job.instance.id
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4822:
URL: https://github.com/apache/inlong/pull/4822#discussion_r910911423
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/db/RocksDbImp.java:
##########
@@ -239,11 +257,11 @@ public List<KeyValueEntity> search(StateSearchKey searchKey) {
public List<CommandEntity> searchCommands(boolean isAcked) {
List<CommandEntity> results = new LinkedList<>();
try (final RocksIterator it = db.newIterator(
- columnHandlesMap.get(commandFamilyName))) {
+ columnHandlesMap.get(commandFamilyName))) {
Review Comment:
Those lines can be merged into one line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #4822: [INLONG-4821][Agent] Fix the error of null value for key job.instance.id
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #4822:
URL: https://github.com/apache/inlong/pull/4822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org