You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/04/28 10:00:02 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #2363: [SCB--2252]fix discovery revision API not used and other TODOs
liubao68 opened a new pull request #2363:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2363
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2363: [SCB--2252]fix discovery revision API not used and other TODOs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2363:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2363#issuecomment-828445502
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2363](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1c546b) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/b5095c12829af98c7833a804391db24a101b08f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5095c1) will **increase** coverage by `0.01%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head f1c546b differs from pull request most recent head f560c20. Consider uploading reports for the commit f560c20 to get more accurate results
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2363 +/- ##
============================================
+ Coverage 80.28% 80.29% +0.01%
+ Complexity 1383 1380 -3
============================================
Files 1559 1559
Lines 41516 41502 -14
Branches 3483 3483
============================================
- Hits 33332 33325 -7
+ Misses 6677 6672 -5
+ Partials 1507 1505 -2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../common/rest/codec/param/BodyProcessorCreator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9wYXJhbS9Cb2R5UHJvY2Vzc29yQ3JlYXRvci5qYXZh) | `85.10% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../rest/codec/produce/ProduceTextPlainProcessor.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9wcm9kdWNlL1Byb2R1Y2VUZXh0UGxhaW5Qcm9jZXNzb3IuamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...comb/common/rest/definition/RestOperationMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9kZWZpbml0aW9uL1Jlc3RPcGVyYXRpb25NZXRhLmphdmE=) | `87.20% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...demo/jaxrs/client/MultiErrorCodeServiceClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvTXVsdGlFcnJvckNvZGVTZXJ2aWNlQ2xpZW50LmphdmE=) | `88.95% <ø> (-0.13%)` | `12.00 <0.00> (-1.00)` | |
| [.../apache/servicecomb/registry/DiscoveryManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvRGlzY292ZXJ5TWFuYWdlci5qYXZh) | `96.55% <ø> (-0.06%)` | `0.00 <0.00> (ø)` | |
| [...org/apache/servicecomb/registry/api/Discovery.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvYXBpL0Rpc2NvdmVyeS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...b/registry/api/registry/MicroserviceInstances.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvYXBpL3JlZ2lzdHJ5L01pY3Jvc2VydmljZUluc3RhbmNlcy5qYXZh) | `97.29% <ø> (-0.08%)` | `0.00 <0.00> (ø)` | |
| [...stry/lightweight/AbstractLightweightDiscovery.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1saWdodHdlaWdodC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvbGlnaHR3ZWlnaHQvQWJzdHJhY3RMaWdodHdlaWdodERpc2NvdmVyeS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/servicecomb/localregistry/LocalDiscovery.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9jYWxyZWdpc3RyeS9Mb2NhbERpc2NvdmVyeS5qYXZh) | `85.71% <ø> (+3.36%)` | `10.00 <0.00> (-1.00)` | :arrow_up: |
| [...e/servicecomb/schemadiscovery/SchemaDiscovery.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zY2hlbWEtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zY2hlbWFkaXNjb3ZlcnkvU2NoZW1hRGlzY292ZXJ5LmphdmE=) | `53.65% <ø> (+0.17%)` | `12.00 <0.00> (-1.00)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b5095c1...f560c20](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2363?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2363: [SCB--2252]fix discovery revision API not used and other TODOs
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2363:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org