You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/03 15:23:09 UTC

[GitHub] [airflow] eladkal edited a comment on pull request #17987: AwsBaseHook make `client_type` & `resource_type` optional params for `get_client_type` & `get_resource_type`

eladkal edited a comment on pull request #17987:
URL: https://github.com/apache/airflow/pull/17987#issuecomment-912618613


   As suggested I added deprecation for `client_type`/`resource_type` in the function.
   This may leads to a very confusing cases like:
   
   `emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type(client_type='dynamodb')`
   
   The values should be set only from the hook
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org