You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "wolfboys (via GitHub)" <gi...@apache.org> on 2023/02/07 03:50:05 UTC

[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2304: [Improve] Rename streampark-flink-submit module

wolfboys opened a new pull request, #2304:
URL: https://github.com/apache/incubator-streampark/pull/2304

   Currently, the implementation of flink job submit and cancel in the streampark-flink-submit module, As more and more features are added to streampark-flink-submit module(e.g: flink-cluster deploy, shutdown, flink-job trigger savepoint ...),
   
   The streampark-flink-submit module is not only doing submission-related work, it is actually a client for operating flink.
   The new module name streampark-flink-client would be better.
   
   so, We need to rename this module.
   
   ## What changes were proposed in this pull request
   
   Issue Number: close #2303
   
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verifying this change
   
   <!--*(Please pick either of the following options)*-->
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added integration tests for end-to-end.*
   - *Added *Test to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2304: [Improve] Rename streampark-flink-submit module

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2304:
URL: https://github.com/apache/incubator-streampark/pull/2304#issuecomment-1420159537

   cc @1996fanrui PTAL, thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] MonsterChenzhuo commented on pull request #2304: [Improve] Rename streampark-flink-submit module

Posted by "MonsterChenzhuo (via GitHub)" <gi...@apache.org>.
MonsterChenzhuo commented on PR #2304:
URL: https://github.com/apache/incubator-streampark/pull/2304#issuecomment-1422132593

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys merged pull request #2304: [Improve] Rename streampark-flink-submit module

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2304:
URL: https://github.com/apache/incubator-streampark/pull/2304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org