You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/11/16 23:24:40 UTC
[GitHub] [solr] HoustonPutman opened a new pull request #420: SOLR-15803: Allow AssignStrategy to process multiple AssignRequests with cross-coordination
HoustonPutman opened a new pull request #420:
URL: https://github.com/apache/solr/pull/420
https://issues.apache.org/jira/browse/SOLR-15803
Tested and works with an extremely basic setup, but this needs more unit tests, especially with the autoscaling stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #420: SOLR-15803: Allow AssignStrategy to process multiple AssignRequests with cross-coordination
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #420:
URL: https://github.com/apache/solr/pull/420#discussion_r761497602
##########
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/ReplaceNodeCmd.java
##########
@@ -96,35 +97,47 @@ public void call(ClusterState state, ZkNodeProps message, NamedList<Object> resu
// map of collectionName_coreNodeName to watchers
Map<String, CollectionStateWatcher> watchers = new HashMap<>();
List<ZkNodeProps> createdReplicas = new ArrayList<>();
+ List<Replica> createdReplicaObjects = new ArrayList<>();
Review comment:
*ModifiedButNotUsed:* A collection or proto builder was created, but its values were never accessed. [(details)](https://errorprone.info/bugpattern/ModifiedButNotUsed)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #420: SOLR-15803: Allow AssignStrategy to process multiple AssignRequests with cross-coordination
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #420:
URL: https://github.com/apache/solr/pull/420#issuecomment-970819371
@sigram as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #420: SOLR-15803: Allow AssignStrategy to process multiple AssignRequests with cross-coordination
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #420:
URL: https://github.com/apache/solr/pull/420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] murblanc commented on pull request #420: SOLR-15803: Allow AssignStrategy to process multiple AssignRequests with cross-coordination
Posted by GitBox <gi...@apache.org>.
murblanc commented on pull request #420:
URL: https://github.com/apache/solr/pull/420#issuecomment-989953532
Sorry missed your review request.
Had a quick look today, nothing shocking. Thanks for the cleaning up you also did in the code.
Minor: some javadoc text (or were these comments?) was not updated when the placement requests became plural (the variable names did get updated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #420: SOLR-15803: Allow AssignStrategy to process multiple AssignRequests with cross-coordination
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #420:
URL: https://github.com/apache/solr/pull/420#issuecomment-990032430
> Minor: some javadoc text (or were these comments?) was not updated when the placement requests became plural (the variable names did get updated).
Will look through and update those. Thanks for taking a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org