You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/14 14:17:05 UTC
[GitHub] [skywalking] hanahmily commented on issue #4511: [DISCUSSION]
Optimize configurations `application.yml`
hanahmily commented on issue #4511: [DISCUSSION] Optimize configurations `application.yml`
URL: https://github.com/apache/skywalking/issues/4511#issuecomment-599067501
LGTM. For docker and k8s, here are some tips for you:
1. Simplify `docker-entrypoint.sh`, we can remove most of its content because the main purpose is to select one from multiple options. I suggest you keep the same naming pattern with entrypoint since your example follows this way.
1. K8s Helm chart would get benefits from it. If we keep the same selector name, helm chart doesn't need any change @innerpeacez Is that ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services