[GitHub] [spark] rdblue commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #24382: [SPARK-27330][SS] support task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r309423436
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterTable.scala
 ##########
 @@ -141,17 +143,33 @@ class ForeachDataWriter[T](
       writer.process(rowConverter(record))
     } catch {
       case t: Throwable =>
-        writer.close(t)
+        closeWriter(t)
         throw t
     }
   }
 
   override def commit(): WriterCommitMessage = {
-    writer.close(null)
+    closeWriter(null)
     ForeachWriterCommitMessage
   }
 
-  override def abort(): Unit = {}
+  override def abort(): Unit = {
 
 Review comment:
   What is the use case for passing the exception to the writer? Shouldn't the writer always take the same action on abort, no matter what the reason to abort was?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org