You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2015/12/09 16:58:14 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-309 upgrade commons-collect...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/260
ARTEMIS-309 upgrade commons-collections
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-309
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit 05382ac06804de08fac4a4cf0a41fcc27c868f78
Author: jbertram <jb...@apache.org>
Date: 2015-12-09T15:56:05Z
ARTEMIS-309 upgrade commons-collections
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Improve AeroGearBasicServerTest by ...
Posted by thiagokronig <gi...@git.apache.org>.
Github user thiagokronig closed the pull request at:
https://github.com/apache/activemq-artemis/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix AeroGearBasicServerTest by bind...
Posted by thiagokronig <gi...@git.apache.org>.
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/260#issuecomment-102047182
Occasionally I have something running on 8080.
I thought that it would be better than binding to a fixed port so common as 8080.
Also, doing so reduces the chance of having parallels tests interfere with each other.
This PR it is not a Fix, just an opinionated Improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-309 upgrade commons-collect...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Improve AeroGearBasicServerTest by ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/260#issuecomment-102053241
The same thing could apply to any other test.. I don't think it's a valid change...
I could accept making it something else but fixed... change the port to 8083 and I think it should be fine (use any port you like) and I will get it merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Improve AeroGearBasicServerTest by ...
Posted by thiagokronig <gi...@git.apache.org>.
Github user thiagokronig commented on the pull request:
https://github.com/apache/activemq-artemis/pull/260#issuecomment-102563792
I agree. Closing it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---