You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Piotr Wikie? <pi...@allegrogroup.com> on 2016/02/17 16:26:20 UTC
Review Request 43651: HIVE-13075 | Metastore shuts down when no
delegation token is found in ZooKeeper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43651/
-----------------------------------------------------------
Review request for hive.
Summary (updated)
-----------------
HIVE-13075 | Metastore shuts down when no delegation token is found in ZooKeeper
Repository: hive-git
Description (updated)
-------
When you have multiple metastore instances storing tokens in ZooKeeper, there could be a race condition in ExpiredTokenRemover causing one metastore to remove tokens already removed by another instance. This is a simple solution for that problem. `null` is perfectly fine as a return value in `ZooKeeperTokenStore::getToken`.
Diffs
-----
Diff: https://reviews.apache.org/r/43651/diff/
Testing
-------
Thanks,
Piotr Wikie?
Re: Review Request 43651: HIVE-13075 | Metastore shuts down when no
delegation token is found in ZooKeeper
Posted by Piotr Wikie? <pi...@allegrogroup.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43651/
-----------------------------------------------------------
(Updated Lut 17, 2016, 5:55 po południu)
Review request for hive.
Changes
-------
I've tested in only in hive 1 (branch-1 and branch-1.2)
Repository: hive-git
Description
-------
When you have multiple metastore instances storing tokens in ZooKeeper, there could be a race condition in ExpiredTokenRemover causing one metastore to remove tokens already removed by another instance. This is a simple solution for that problem. `null` is perfectly fine as a return value in `ZooKeeperTokenStore::getToken`.
Diffs
-----
shims/common/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java 745e467
Diff: https://reviews.apache.org/r/43651/diff/
Testing
-------
Thanks,
Piotr Wikie?
Re: Review Request 43651: HIVE-13075 | Metastore shuts down when no
delegation token is found in ZooKeeper
Posted by Piotr Wikie? <pi...@allegrogroup.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43651/
-----------------------------------------------------------
(Updated Lut 17, 2016, 3:27 po południu)
Review request for hive.
Repository: hive-git
Description
-------
When you have multiple metastore instances storing tokens in ZooKeeper, there could be a race condition in ExpiredTokenRemover causing one metastore to remove tokens already removed by another instance. This is a simple solution for that problem. `null` is perfectly fine as a return value in `ZooKeeperTokenStore::getToken`.
Diffs (updated)
-----
shims/common/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java 745e467
Diff: https://reviews.apache.org/r/43651/diff/
Testing
-------
Thanks,
Piotr Wikie?