You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "dossett (via GitHub)" <gi...@apache.org> on 2025/09/22 15:53:55 UTC
[PR] MINOR: Remove unused parquet-thrift dependencies [parquet-java]
dossett opened a new pull request, #3323:
URL: https://github.com/apache/parquet-java/pull/3323
<!--
Thanks for opening a pull request!
If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing
Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose
and format pull request title as below:
GH-${GITHUB_ISSUE_ID}: ${SUMMARY}
or simply use the title below if it is a minor issue:
MINOR: ${SUMMARY}
-->
### Rationale for this change
There are some unnecessary dependencies in parquet-thrift. Comments for a couple of them suggest that they're still needed for pig integration, but my local builds worked fine without them.
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
NO
<!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Remove unused parquet-thrift dependencies [parquet-java]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #3323:
URL: https://github.com/apache/parquet-java/pull/3323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Remove unused parquet-thrift dependencies [parquet-java]
Posted by "dossett (via GitHub)" <gi...@apache.org>.
dossett commented on PR #3323:
URL: https://github.com/apache/parquet-java/pull/3323#issuecomment-3320528348
Learned that the project requires(?) some dependency declarations above and beyond what's required to build. Also sorted out other unused dependencies. 🤞 tests will pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] MINOR: Remove unused parquet-thrift dependencies [parquet-java]
Posted by "dossett (via GitHub)" <gi...@apache.org>.
dossett commented on PR #3323:
URL: https://github.com/apache/parquet-java/pull/3323#issuecomment-3321324842
Missed one test/provided scope. fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org