You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ck...@apache.org on 2019/06/19 18:30:12 UTC

[logging-log4j2] branch master updated (b7fd433 -> 0f99d53)

This is an automated email from the ASF dual-hosted git repository.

ckozak pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git.


    from b7fd433  Fix deprecated markers
     new 5962624  LOG4J2-2613 - Attempt to eliminate test failures by requiring more logs before rollover
     new 0f99d53  LOG4J2-2613: No longer ignore RollingAppenderSizeWithTimeTest.testAppender

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../core/appender/rolling/RollingAppenderSizeWithTimeTest.java      | 6 ++----
 log4j-core/src/test/resources/log4j-rolling-size-with-time.xml      | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)


[logging-log4j2] 01/02: LOG4J2-2613 - Attempt to eliminate test failures by requiring more logs before rollover

Posted by ck...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ckozak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit 5962624763bb4d6147e5befd3316db50ab39a8d9
Author: Ralph Goers <rg...@apache.org>
AuthorDate: Mon Jun 17 07:59:14 2019 -0700

    LOG4J2-2613 - Attempt to eliminate test failures by requiring more logs before rollover
---
 .../log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java  | 4 ++--
 log4j-core/src/test/resources/log4j-rolling-size-with-time.xml        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java
index 5b78aeb..b79ef1f 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java
@@ -63,12 +63,12 @@ public class RollingAppenderSizeWithTimeTest {
     @Ignore("LOG4J2-2613")
     public void testAppender() throws Exception {
         final List<String> messages = new ArrayList<>();
-        for (int i = 0; i < 1000; ++i) {
+        for (int i = 0; i < 5000; ++i) {
             final String message = "This is test message number " + i;
             messages.add(message);
             logger.debug(message);
             if (i % 100 == 0) {
-                Thread.sleep(500);
+                Thread.sleep(10);
             }
         }
         if (!loggerContextRule.getLoggerContext().stop(30, TimeUnit.SECONDS)) {
diff --git a/log4j-core/src/test/resources/log4j-rolling-size-with-time.xml b/log4j-core/src/test/resources/log4j-rolling-size-with-time.xml
index b3dd0d9..a006627 100644
--- a/log4j-core/src/test/resources/log4j-rolling-size-with-time.xml
+++ b/log4j-core/src/test/resources/log4j-rolling-size-with-time.xml
@@ -28,7 +28,7 @@
       <PatternLayout>
         <Pattern>%m%n</Pattern>
       </PatternLayout>
-      <SizeBasedTriggeringPolicy size="1000" />
+      <SizeBasedTriggeringPolicy size="5000" />
       <DefaultRolloverStrategy max="500"/>
     </RollingFile>
   </Appenders>


[logging-log4j2] 02/02: LOG4J2-2613: No longer ignore RollingAppenderSizeWithTimeTest.testAppender

Posted by ck...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ckozak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit 0f99d5371a90c228d901eb1d73a2e50589d3870e
Author: Carter Kozak <ck...@apache.org>
AuthorDate: Wed Jun 19 14:28:49 2019 -0400

    LOG4J2-2613: No longer ignore RollingAppenderSizeWithTimeTest.testAppender
---
 .../log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java
index b79ef1f..7370060 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeWithTimeTest.java
@@ -28,7 +28,6 @@ import org.apache.commons.compress.utils.IOUtils;
 import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.RuleChain;
@@ -60,7 +59,6 @@ public class RollingAppenderSizeWithTimeTest {
     }
 
     @Test
-    @Ignore("LOG4J2-2613")
     public void testAppender() throws Exception {
         final List<String> messages = new ArrayList<>();
         for (int i = 0; i < 5000; ++i) {