You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/05/25 23:18:06 UTC

[GitHub] [thrift] Jens-G commented on a change in pull request #2395: THRIFT-5419: Update TThreadPoolAsyncServer.Execute to be async/await

Jens-G commented on a change in pull request #2395:
URL: https://github.com/apache/thrift/pull/2395#discussion_r639269853



##########
File path: lib/netstd/Thrift/Server/TThreadPoolAsyncServer.cs
##########
@@ -218,11 +218,11 @@ public override async Task ServeAsync(CancellationToken cancellationToken)
         /// threadContext will be a TTransport instance
         /// </summary>
         /// <param name="threadContext"></param>
-        private void Execute(object threadContext)
+        private async void ExecuteAsync(TTransport client)
         {

Review comment:
       `async void` is usually a bad combination that should be avoided (pun intended)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org