You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/13 19:45:53 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25109: [SPARK-28343][SQL][TEST] Enabling cartesian product and ansi mode for PostgreSQL testing

dongjoon-hyun commented on a change in pull request #25109: [SPARK-28343][SQL][TEST] Enabling cartesian product and ansi mode for PostgreSQL testing
URL: https://github.com/apache/spark/pull/25109#discussion_r303216698
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/boolean.sql
 ##########
 @@ -17,19 +17,19 @@ SELECT 1 AS one;
 
 SELECT true AS true;
 
-SELECT false AS false;
+SELECT false AS `false`;
 
 Review comment:
   Shall we add `SPARK-28349` as a comment before this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org