You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixb <gi...@git.apache.org> on 2015/09/18 07:25:58 UTC
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
GitHub user felixb opened a pull request:
https://github.com/apache/spark/pull/8810
docs/running-on-mesos.md: state default values in default column
This PR simply uses the default value column for defaults.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixb/spark fix_mesos_doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8810.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8810
----
commit 09b4e15f0dfe903ac70c0d6f4a8fcf06dac6d78b
Author: Felix Bechstein <fe...@otto.de>
Date: 2015-09-18T05:25:00Z
docs/running-on-mesos.md: state default values in default column
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8810#issuecomment-141351178
Actually I will just merge this and address the comment when I merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8810#discussion_r39825352
--- Diff: docs/running-on-mesos.md ---
@@ -332,21 +332,21 @@ See the [configuration page](configuration.html) for information on Spark config
</tr>
<tr>
<td><code>spark.mesos.principal</code></td>
- <td>Framework principal to authenticate to Mesos</td>
+ <td>(none)</td>
<td>
Set the principal with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.secret</code></td>
- <td>Framework secret to authenticate to Mesos</td>
+ <td>(none)/td>
<td>
Set the secret with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.role</code></td>
- <td>Role for the Spark framework</td>
+ <td>*</td>
--- End diff --
can you put <code> around this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
Posted by felixb <gi...@git.apache.org>.
Github user felixb commented on a diff in the pull request:
https://github.com/apache/spark/pull/8810#discussion_r39825730
--- Diff: docs/running-on-mesos.md ---
@@ -332,21 +332,21 @@ See the [configuration page](configuration.html) for information on Spark config
</tr>
<tr>
<td><code>spark.mesos.principal</code></td>
- <td>Framework principal to authenticate to Mesos</td>
+ <td>(none)</td>
<td>
Set the principal with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.secret</code></td>
- <td>Framework secret to authenticate to Mesos</td>
+ <td>(none)/td>
<td>
Set the secret with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.role</code></td>
- <td>Role for the Spark framework</td>
+ <td>*</td>
--- End diff --
I don't see anything.
Should I set it to `"*"`, `(*)` or ` * ` with blanks on each side?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8810#discussion_r39825765
--- Diff: docs/running-on-mesos.md ---
@@ -332,21 +332,21 @@ See the [configuration page](configuration.html) for information on Spark config
</tr>
<tr>
<td><code>spark.mesos.principal</code></td>
- <td>Framework principal to authenticate to Mesos</td>
+ <td>(none)</td>
<td>
Set the principal with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.secret</code></td>
- <td>Framework secret to authenticate to Mesos</td>
+ <td>(none)/td>
<td>
Set the secret with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.role</code></td>
- <td>Role for the Spark framework</td>
+ <td>*</td>
--- End diff --
I've already merged this though so don't worry about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8810#discussion_r39825764
--- Diff: docs/running-on-mesos.md ---
@@ -332,21 +332,21 @@ See the [configuration page](configuration.html) for information on Spark config
</tr>
<tr>
<td><code>spark.mesos.principal</code></td>
- <td>Framework principal to authenticate to Mesos</td>
+ <td>(none)</td>
<td>
Set the principal with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.secret</code></td>
- <td>Framework secret to authenticate to Mesos</td>
+ <td>(none)/td>
<td>
Set the secret with which Spark framework will use to authenticate with Mesos.
</td>
</tr>
<tr>
<td><code>spark.mesos.role</code></td>
- <td>Role for the Spark framework</td>
+ <td>*</td>
--- End diff --
Oh I meant
```
<code>*</code>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8810
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: docs/running-on-mesos.md: state default values...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8810#issuecomment-141349184
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org