You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/04/21 10:56:23 UTC

[GitHub] [sling-parent] kwin commented on a diff in pull request #33: SLING-11841 Target Java 11 by default

kwin commented on code in PR #33:
URL: https://github.com/apache/sling-parent/pull/33#discussion_r1173632916


##########
sling-parent/pom.xml:
##########
@@ -56,7 +56,7 @@
               - 9: Java 9
               - 10..19: Java 10-19
         -->
-        <sling.java.version>8</sling.java.version>
+        <sling.java.version>11</sling.java.version>

Review Comment:
   This PR is only about the default. With this PR applied, the parent still supports targeting Java 8 (and building with JDK8). So the profiles removal and the stricter enforcement of the values are part of SLING-11842 indeed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org