You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Ran Tao (Jira)" <ji...@apache.org> on 2023/07/10 02:21:00 UTC

[jira] [Commented] (CALCITE-5823) Remove commons-collections dependency from innodb

    [ https://issues.apache.org/jira/browse/CALCITE-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741444#comment-17741444 ] 

Ran Tao commented on CALCITE-5823:
----------------------------------

[~julianhyde] hi, Julian. I thought of that too. I will fix it later.

> Remove commons-collections dependency from innodb
> -------------------------------------------------
>
>                 Key: CALCITE-5823
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5823
>             Project: Calcite
>          Issue Type: Improvement
>          Components: innodb-adapter
>    Affects Versions: 1.34.0
>            Reporter: Ran Tao
>            Assignee: Ran Tao
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.35.0
>
>
> Currently,  {{CollectionsUtils}} is only used in a few places in the InnoDb adapter, and the only methods used are {{isEmpty}} and {{isNotEmpty}}. 
> The only difference between {{CollectionUtils.isEmpty}} and {{list.isEmpty}} is the behavior if {{list}} is null. Modern coding practices would ensure that {{list}} is not null unless specified in its type.
> So we can safely remove it to avoid using an entire library just for the sake of using {{isEmpty}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)