[GitHub] flink pull request #2224: [docs] {hotfix} fix errors and formatting in NiFi ...

[rmetzger <gi...@git.apache.org>]

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2224#discussion_r70224736
  
    --- Diff: docs/apis/streaming/connectors/nifi.md ---
    @@ -89,40 +93,51 @@ val nifiSource = new NiFiSource(clientConfig)
     </div>
     
     Here data is read from the Apache NiFi Output Port called "Data for Flink" which is part of Apache NiFi 
    -Site-to_site protocol configuration.
    +Site-to-site protocol configuration.
      
     #### Apache NiFi Sink
     
    -The connector provides a Sink for writing data from Apache NiFi to Apache Flink.
    +The connector provides a Sink for writing data from Apache Flink to Apache NiFi.
     
    -The class `NiFiSink(\u2026)` provides a constructor for instantiating a `NiFiSink`. `NiFiSink(SiteToSiteClientConfig, NiFiDataPacketBuilder<T>)` constructs a `NiFiSink(\u2026)` given the client's `SiteToSiteConfig` and a `NiFiDataPacketBuilder` that converts data from Flink to `NiFiDataPacket` to be ingested by NiFi.
    +The class `NiFiSink(\u2026)` provides a constructor for instantiating a `NiFiSink`.
    +
    +- `NiFiSink(SiteToSiteClientConfig, NiFiDataPacketBuilder<T>)` constructs a `NiFiSink(\u2026)` given the client's `SiteToSiteConfig` and a `NiFiDataPacketBuilder` that converts data from Flink to `NiFiDataPacket` to be ingested by NiFi.
           
     Example:
           
     <div class="codetabs" markdown="1">
     <div data-lang="java" markdown="1">
     {% highlight java %}
    +StreamExecutionEnvironment streamExecEnv = StreamExecutionEnvironment.getExecutionEnvironment();
    +
     SiteToSiteClientConfig clientConfig = new SiteToSiteClient.Builder()
             .url("http://localhost:8080/nifi")
             .portName("Data from Flink")
             .requestBatchCount(5)
             .buildConfig();
     
    -SinkFunction<NiFiDataPacket> nifiSink = new NiFiSink<>(clientConfig);
    +SinkFunction<NiFiDataPacket> nifiSink = new NiFiSink<>(clientConfig, new NiFiDataPacketBuilder<T>() {...});
    +
    +streamExec
    --- End diff --
    
    I think that line can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---