You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/22 21:47:52 UTC
Review Request 67708: Added `profiler_tests.cpp` to the libprocess
cmake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67708/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
Description
-------
Added `profiler_tests.cpp` to the libprocess cmake build.
Diffs
-----
3rdparty/libprocess/src/tests/CMakeLists.txt 8c1353b442d5fc7b2e796a4d87f5b41389d4e1c3
Diff: https://reviews.apache.org/r/67708/diff/1/
Testing
-------
`make check` (cmake)
`./support/mesos-tidy.sh`
Thanks,
Benjamin Bannier
Re: Review Request 67708: Added `profiler_tests.cpp` to the
libprocess cmake build.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67708/#review205319
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 22, 2018, 2:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67708/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 2:47 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `profiler_tests.cpp` to the libprocess cmake build.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/CMakeLists.txt 8c1353b442d5fc7b2e796a4d87f5b41389d4e1c3
>
>
> Diff: https://reviews.apache.org/r/67708/diff/1/
>
>
> Testing
> -------
>
> `make check` (cmake)
> `./support/mesos-tidy.sh`
>
>
> Thanks,
>
> Benjamin Bannier
>
>