You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by Andrew Lindesay <ap...@lindesay.co.nz> on 2014/05/13 11:19:11 UTC

CAY-1932 for 3.2 Next Milestone Release

Hello;

Could somebody have a quick review of CAY-1932 + patch which covers some 
improvements to the generation of EJBQL from Expression objects and let 
me know if it would be possible to get that into the next 3.2 milestone 
release?

Regards;

-- 
Andrew Lindesay

Re: CAY-1932 for 3.2 Next Milestone Release

Posted by Andrew Lindesay <ap...@lindesay.co.nz>.
Hi Andrus;

Actually I had a look at that now while I'm in that space and have added 
an additional patch "CAY-1932_14may2014_extratypes.patch" to CAY-1932 to 
cover those additional types.

Regards;

On 14/05/14 1:05 pm, Andrew Lindesay wrote:
> Hi Andrus;
>
> Thanks for applying the patch.  Good point on the floats and doubles;
> maybe I can take a look at that at some point.
>
> Regards;
>
> On 13/05/14 11:33 pm, Andrus Adamchik wrote:
>> Applied. Thanks a lot for the patch. I can think of a possible
>> enhancement - handling of floats and doubles. IIRC we can parse those (?)
>> Also I’ve been considering for some time to support date/time
>> literals. After all there’s ISO8601 format that is well understaood
>> and easy to parse. Something we may add to both Expression and EJBQL
>> parsers.
>


-- 
Andrew Lindesay

Re: CAY-1932 for 3.2 Next Milestone Release

Posted by Andrew Lindesay <ap...@lindesay.co.nz>.
Hi Andrus;

Thanks for applying the patch.  Good point on the floats and doubles; 
maybe I can take a look at that at some point.

Regards;

On 13/05/14 11:33 pm, Andrus Adamchik wrote:
> Applied. Thanks a lot for the patch. I can think of a possible enhancement - handling of floats and doubles. IIRC we can parse those (?)
> Also I’ve been considering for some time to support date/time literals. After all there’s ISO8601 format that is well understaood and easy to parse. Something we may add to both Expression and EJBQL parsers.

-- 
Andrew Lindesay

Re: CAY-1932 for 3.2 Next Milestone Release

Posted by Andrus Adamchik <an...@objectstyle.org>.
Applied. Thanks a lot for the patch. I can think of a possible enhancement - handling of floats and doubles. IIRC we can parse those (?)

Also I’ve been considering for some time to support date/time literals. After all there’s ISO8601 format that is well understaood and easy to parse. Something we may add to both Expression and EJBQL parsers.

Thanks,
Andrus



On May 13, 2014, at 5:19 AM, Andrew Lindesay <ap...@lindesay.co.nz> wrote:
> Hello;
> 
> Could somebody have a quick review of CAY-1932 + patch which covers some improvements to the generation of EJBQL from Expression objects and let me know if it would be possible to get that into the next 3.2 milestone release?
> 
> Regards;
> 
> -- 
> Andrew Lindesay
>