[GitHub] [iceberg] amogh-jahagirdar commented on pull request #7576: Core: Table metadata file deletion should check `gc.enabled` property

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on PR #7576:
URL: https://github.com/apache/iceberg/pull/7576#issuecomment-1551861178

   Thanks @ajantha-bhat , this looks related to https://github.com/apache/iceberg/issues/4159
   
   So my take is that tables own their metadata files and that `gc.enabled` should not actually be part of the determination to delete the files or not. But my definition is based on `gc.enabled` really being tied to being used as a mechanism to prevent dangerous actions such as cleaning up files which are not a part of the table. 
   
   Right now `CatalogUtil` will only cleanup data files iff gc is enabled. `ExpireSnapshots` can only be run if gc is enabled and it it doesn't even delete metadata files. 
   
   You mentioned 
   
   ```
   This behaviour should be unified with the other Iceberg metadata file deletion (that is honouring the gc.enabled property)
   ```
   
   Curious where are you seeing this?
   
   Interested in knowing what others think though!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org