You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by jo...@apache.org on 2010/02/12 02:04:47 UTC

svn commit: r909196 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java

Author: johnh
Date: Fri Feb 12 01:04:46 2010
New Revision: 909196

URL: http://svn.apache.org/viewvc?rev=909196&view=rev
Log:
Clean up OAuthRequest URI parsing exception case.


Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java?rev=909196&r1=909195&r2=909196&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java Fri Feb 12 01:04:46 2010
@@ -500,7 +500,13 @@
       case URL_ONLY:
         break;
       case URL_AND_FORM_PARAMS:
-        params.addAll(sanitize(OAuth.decodeForm(base.getPostBodyAsString())));
+        try {
+          params.addAll(sanitize(OAuth.decodeForm(base.getPostBodyAsString())));
+        } catch (IllegalArgumentException e) {
+          // Occurs if OAuth.decodeForm finds an invalid URL to decode.
+          throw responseParams.oauthRequestException(OAuthError.INVALID_REQUEST,
+              "Could not decode body", e);
+        }
         break;
       case URL_AND_BODY_HASH:
         try {