[GitHub] [maven] cstamas commented on pull request #555: [MNG-7055] Fix G level metadata handling

[GitBox <gi...@apache.org>]

cstamas commented on pull request #555:
URL: https://github.com/apache/maven/pull/555#issuecomment-931320282


   > Does this mean that the `AddPluginArtifactMetadataMojo` from maven-plugin-plugin is completely useless ? This is actually one of the pain point because it depends on the `GroupRepositoryMetadata` which is in maven-compat.
   
   Yes and no: Yes, as _we could_ get the only missing piece even without it (the goalPrefix that is plugin configuration). The "price" would be high, go thru plugin config/DOM stuff.... No, as due that above, it made this PR stupid simple (just reuse the data that mojo gave to us).
   
   In general (and that's why I created this PR initially to drop this useless mojo) I'd drop it, but this seems like "simple first step", and later we can change it at will. Given m-plugin-p is "just a plugin" but is still quite often referenced in core (so somewhat not "just a plugin"), I think we could do more here, for example change the mojo to just stick some values somewhere (ie. session) and alter the provider in maven core and voila, GroupRepositoryMetadata is not needed....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org