You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wolf427 (GitHub)" <gi...@apache.org> on 2019/03/22 07:43:43 UTC

[GitHub] [incubator-dubbo-admin] wolf427 opened pull request #341: Fix some UI bug on test module

1. The service test page will throw undefined exception in console if the "service" parameter in url is null.
2. Keep the style of service test page consistent with other pages

[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] wolf427 commented on issue #341: Fix some UI bug on test module

Posted by "wolf427 (GitHub)" <gi...@apache.org>.
Before:
![before](https://user-images.githubusercontent.com/5528338/54860248-575ed300-4d52-11e9-8ab3-f11a8627296e.png)
Now:
![now](https://user-images.githubusercontent.com/5528338/54860234-2aaabb80-4d52-11e9-945a-9ea611bf4bc0.png)


[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] codecov-io commented on issue #341: Fix some UI bug on test module

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=h1) Report
> Merging [#341](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-admin/commit/1faaec0b747604897c4a9af6c67222744231ecd7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             develop     #341   +/-   ##
==========================================
  Coverage      22.37%   22.37%           
+ Complexity       290      289    -1     
==========================================
  Files             76       76           
  Lines           3142     3142           
  Branches         526      526           
==========================================
  Hits             703      703           
  Misses          2364     2364           
  Partials          75       75
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=footer). Last update [1faaec0...c4e996b](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] kezhenxu94 commented on pull request #341: Fix some UI bug on test module

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
`query['service'] ? query['service'] : ''` can be replaced with a simpler way `query['service'] || ''`

[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] codecov-io commented on issue #341: Fix some UI bug on test module

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=h1) Report
> Merging [#341](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-admin/commit/1faaec0b747604897c4a9af6c67222744231ecd7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             develop     #341   +/-   ##
==========================================
  Coverage      22.37%   22.37%           
+ Complexity       290      289    -1     
==========================================
  Files             76       76           
  Lines           3142     3142           
  Branches         526      526           
==========================================
  Hits             703      703           
  Misses          2364     2364           
  Partials          75       75
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=footer). Last update [1faaec0...9a247dc](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] wolf427 commented on issue #341: Fix some UI bug on test module

Posted by "wolf427 (GitHub)" <gi...@apache.org>.
@kezhenxu94 
THX for your advice

[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] codecov-io commented on issue #341: Fix some UI bug on test module

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=h1) Report
> Merging [#341](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-admin/commit/1faaec0b747604897c4a9af6c67222744231ecd7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             develop     #341   +/-   ##
==========================================
  Coverage      22.37%   22.37%           
+ Complexity       290      289    -1     
==========================================
  Files             76       76           
  Lines           3142     3142           
  Branches         526      526           
==========================================
  Hits             703      703           
  Misses          2364     2364           
  Partials          75       75
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=footer). Last update [1faaec0...9a247dc](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/341?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/341 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org