You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/30 12:12:24 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #1375: Consolidate `ConstantFolding` and `SimplifyExpression`

alamb commented on pull request #1375:
URL: https://github.com/apache/arrow-datafusion/pull/1375#issuecomment-982578141


   The new tpch query test added in #1368 by @viirya  is already coming in handy to prevent regressions -- it found a [problem](https://github.com/apache/arrow-datafusion/runs/4366849992?check_suite_focus=true) with an earlier version of this pr where simplification wasn't done until after the other optimizations. ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org