[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4551: Cleanup volume information from db when deleted

[GitBox <gi...@apache.org>]

Pearl1594 commented on a change in pull request #4551:
URL: https://github.com/apache/cloudstack/pull/4551#discussion_r660598616



##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -392,15 +405,16 @@ protected Answer copyVolumeBetweenPools(DataObject srcData, DataObject destData)
                     return answer;
                 }
             } catch (Exception e) {
-                if (imageStore.exists(objOnImageStore)) {
+                if (objOnImageStore != null) {
                     objOnImageStore.processEvent(Event.OperationFailed);
                     imageStore.delete(objOnImageStore);

Review comment:
       Haven't had the chance to get to testing this yet @sureshanaparti  - Will do it by end of this week. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org