You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/28 05:31:57 UTC

[GitHub] [flink] guoweiM commented on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

guoweiM commented on pull request #13808:
URL: https://github.com/apache/flink/pull/13808#issuecomment-717708815


   > I have some comments that have mainly to do with unused methods and base classes that can be made concrete. I have pushed my changes here (to make sure that I do not break anything :) ) https://github.com/kl0u/flink/tree/FLINK-19834.
   > 
   > Let me know what you think @guoweiM
   
   Thanks @kl0u. I would look at it.   :-)
   I think you are right that these unused methods could removed in this pr. We could add it back when we need it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org