[GitHub] [spark] cloud-fan commented on a change in pull request #24489: [SPARK-27555][SQL] sqlConf of SessionState should load hive-site.xml

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24489: [SPARK-27555][SQL] sqlConf of SessionState  should load hive-site.xml
URL: https://github.com/apache/spark/pull/24489#discussion_r279607994
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
 ##########
 @@ -152,4 +152,9 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach {
       session.sparkContext.hadoopConfiguration.unset(mySpecialKey)
     }
   }
+
+  test("SPARK-27555: Spark SessionState.conf should load hive-site.xml ") {
+    val session = SparkSession.builder().master("local").getOrCreate()
+    assert(session.sessionState.conf.getConfString("hive.in.test") == "true")
 
 Review comment:
   I'm not sure we want to do this. We load `hive-site.xml` into hadoop conf for hive compatibility. But `hive-site.xml` is not a native/official way to load Spark configs, so this conf should not appear in `SessionStage.conf`.
   
   Please use the `spark-defaults.conf`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org