You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/13 13:40:21 UTC

[GitHub] [airflow] potiuk opened a new pull request #18946: Fix --github-image-id flag for Breeze (#18882)

potiuk opened a new pull request #18946:
URL: https://github.com/apache/airflow/pull/18946


   When we moved to github registry, the --github-image-id flag was
   broken as it had pulled the "latest" image when run right after
   pulling the tagged image (and it run that image instead).
   
   This change fixes it and uses GITHUB_PULL_IMAGE_TAG (latest if not
   specified) everywhere where the image is used for running.
   This flag is not persistent so it is not persistent.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-942321046


   Another attempt to do #18882 
   
   This time I am testing it also in my fork for `main` changes:
   
   Building Images: https://github.com/potiuk/airflow/actions/runs/1337712852
   Tests: https://github.com/potiuk/airflow/actions/runs/1337712854
   
   Attempt 2:
   
   Build image: https://github.com/potiuk/airflow/actions/runs/1337712852
   Tests: https://github.com/potiuk/airflow/actions/runs/1337712854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-942321046


   Another attempt to do #18882 
   
   This time I am testing it also in my fork for `main` changes:
   
   Building Images: https://github.com/potiuk/airflow/actions/runs/1337712852
   Tests: https://github.com/potiuk/airflow/actions/runs/1337712854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-942321046






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18946:
URL: https://github.com/apache/airflow/pull/18946


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-942321046


   This time I am testing it also in my fork for `main` changes:
   
   Building Images: https://github.com/potiuk/airflow/actions/runs/1337712852
   Tests: https://github.com/potiuk/airflow/actions/runs/1337712854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-942321046


   Another attempt to do #18882 
   
   This time I am testing it also in my fork for `main` changes:
   
   Building Images: https://github.com/potiuk/airflow/actions/runs/1337712852
   Tests: https://github.com/potiuk/airflow/actions/runs/1337712854
   
   Attempt 2:
   
   Build image: https://github.com/potiuk/airflow/actions/runs/1337812489
   Tests: https://github.com/potiuk/airflow/actions/runs/1337812485


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-942321046






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-943408624


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18946: Fix --github-image-id flag for Breeze (#18882)

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18946:
URL: https://github.com/apache/airflow/pull/18946#issuecomment-942570083


   Looks good this time @jedcunningham > there are failures in my fork but they are unrelated 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org