You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/08 01:34:59 UTC

[GitHub] [spark] sarutak edited a comment on issue #25374: [SPARK-28647][WEBUI] Remove additional-metrics.js

sarutak edited a comment on issue #25374: [SPARK-28647][WEBUI] Remove additional-metrics.js
URL: https://github.com/apache/spark/pull/25374#issuecomment-519231458
 
 
   OK, I've filed.
   @dongjoon-hyun 
   > expand-additional-metrics is used [SPARK-17019][CORE] Expose on-heap and off-heap memory usage in various places (a449162).
   
   It seems `expand-additionl-metrics` is not used in the current code but...
   
   > According to the comment, #22595 (comment), and your comment, it's not working as of now.
   Yes, this PR seems to conflict with #22595.
   
   So, how about having check-boxes for toggle like implemented in Stage Page?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org