You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/14 03:29:46 UTC
[GitHub] [spark] JoshRosen commented on issue #24593: [SPARK-27692][SQL] Add
new optimizer rule to evaluate the deterministic scala udf only once if all
inputs are literals
JoshRosen commented on issue #24593: [SPARK-27692][SQL] Add new optimizer rule to evaluate the deterministic scala udf only once if all inputs are literals
URL: https://github.com/apache/spark/pull/24593#issuecomment-492065223
Instead of defining a new `DeterministicLiteralUDF` rule, could we instead
```scala
override def foldable: Boolean = deterministic && children.forall(_.foldable)
```
on `ScalaUDF`? That would be a slight generalization of the optimization proposed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org