You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by jai1 <gi...@git.apache.org> on 2017/06/22 04:04:32 UTC

[GitHub] incubator-pulsar pull request #517: Reverting d990b171f5d3f14a2a196363fb3155...

GitHub user jai1 opened a pull request:

    https://github.com/apache/incubator-pulsar/pull/517

    Reverting d990b171f5d3f14a2a196363fb315594c46afab6

    ### Motivation
    
    There was a concern that the client will end up using 30x the memory if there is a GC pause or N/W issue. Hence changing the queue size back to 1K.
    
    ### Modifications
    
    Reverted commit d990b171f5d3f14a2a196363fb315594c46afab6
    
    ### Result
    
    Expect to see more ProducerQueueFull error/exceptions in case of GC pauses.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jai1/pulsar queueSize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pulsar/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #517
    
----
commit 7f03f966fdc4f8b8204fdca3532983daa8ac2b58
Author: Jai ASher <ja...@yahoo-inc.com>
Date:   2017-06-22T03:59:47Z

    Reverting d990b171f5d3f14a2a196363fb315594c46afab6

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pulsar pull request #517: Reverting commit d990b1 - changing produ...

Posted by merlimat <gi...@git.apache.org>.

Github user merlimat closed the pull request at:

    https://github.com/apache/incubator-pulsar/pull/517


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pulsar issue #517: Reverting d990b171f5d3f14a2a196363fb315594c46af...

Posted by jai1 <gi...@git.apache.org>.

Github user jai1 commented on the issue:

    https://github.com/apache/incubator-pulsar/pull/517
  
    @rdhabalia @saandrews @msb-at-yahoo @merlimat 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pulsar issue #517: Reverting d990b171f5d3f14a2a196363fb315594c46af...

Posted by merlimat <gi...@git.apache.org>.

Github user merlimat commented on the issue:

    https://github.com/apache/incubator-pulsar/pull/517
  
    Separated from the discussion on whether it's good or not, please use a more descriptive log commit subject :). It can be difficult to understand the change from the git log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---