[jira] [Commented] (SOLR-8902) ReturnFields can return fields that were not requested

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234484#comment-15234484 ] 

Erick Erickson commented on SOLR-8902:
--------------------------------------

[~ryantxu] how confident are you about the testing for this patch (and, BTW, should it be closed?)

The reason I asked is because SOLR-3191 changes a lot of the guts of SolrReturnFields, so much so that I'm having a really hard time reconciling even the very small amount of code changed from that file in this patch. However, just substituting SolrReturnFields.java entirely to trunk works, as in all the tests in ReturnFieldsTests work including the one from this patch. Do you have an opinion here?

> ReturnFields can return fields that were not requested
> ------------------------------------------------------
>
>                 Key: SOLR-8902
>                 URL: https://issues.apache.org/jira/browse/SOLR-8902
>             Project: Solr
>          Issue Type: Bug
>          Components: Response Writers
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 6.1, trunk
>
>         Attachments: SOLR-8902.diff
>
>
> It looks like something changed that now returns all fields requested from lucene, not just the ones request from solr.
> This is the difference between 'fields' and 'okFieldNames' in SolrReturnFields.
> The logic here:
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/SolrReturnFields.java#L141
> adds all the 'fields' to 'okFieldName'
> I think that should be removed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org